post_url tag raises ArgumentError for invalid name #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using post_url tag with invalid name raises TypeError. It should raise ArgumentError and should display detail of the error to fix the error.
| @@ -7,6 +7,7 @@ class PostComparer | |||
|
|
|||
| def initialize(name) | |||
| all, path, date, slug = *name.sub(/^\//, "").match(MATCHER) | |||
| raise ArgumentError unless all | |||
There was a problem hiding this comment.
Can you make this error more descriptive?
| @@ -7,6 +7,7 @@ class PostComparer | |||
|
|
|||
| def initialize(name) | |||
| all, path, date, slug = *name.sub(/^\//, "").match(MATCHER) | |||
| raise ArgumentError.new("invalid post name") unless all | |||
There was a problem hiding this comment.
Can you give the offending post name in here too? Want to be as helpful as possible.
There was a problem hiding this comment.
How about "'#{name}' does not contain valid date and/or title" ?
parkr
added a commit
that referenced
this pull request
Dec 26, 2013
ghost
assigned 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using post_url tag with invalid name raises TypeError.
It should raise ArgumentError and should display detail of the error to
fix the error.