make sure pages with published being false are not generated #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm cool with making the behaviour consistent between the two models. @mattr-, what do you think? |
ghost
assigned 
|
@mattr- what do you think of this pull request? |
| @@ -21,6 +21,11 @@ def to_s | |||
| self.content || '' | |||
| end | |||
|
|
|||
| # Helper methods to query boolean values specified in YAML frontmatter | |||
| %w(published).each do |key| | |||
| define_method("#{key}?") { !(self.data.has_key?(key) && self.data[key] == false) } | |||
There was a problem hiding this comment.
Why do we have to implement this method this way? What prevents us from defining a normal method here?
There was a problem hiding this comment.
@mattr- I was thinking about later we may add similar methods to access boolean values in YAML front matter.
There was a problem hiding this comment.
@mattr- I think you're right here, it's bad to do over-design with inelegant code. I've updated the commit, please have a look.
|
@mattr- When you get a minute, please review & merge if it looks good to you :) |
|
|
mattr-
added a commit
that referenced
this pull request
Jan 22, 2014
mattr-
added a commit
that referenced
this pull request
Jan 22, 2014
|
Thanks @mattr- 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation it says
publishedcan be used both in page and post. But it's only effective in post.This commit makes
publishedfront matter also effective for pages. It also refactors the current implementation ofpublishedfeature.