Use data feature to define docs index #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea why the build is failing on this, though. 😟 |
|
Very nice. The tests don’t cover the documentation. It must be something different introduced by others before your commit. |
|
Next up after this, using the data file to generate the "Back" and "Next" buttons instead of using the page variables. |
|
Looks fine to me. @parkr? |
ghost
assigned
parkr
added a commit
that referenced
this pull request
Jan 16, 2014
parkr
added a commit
that referenced
this pull request
Jan 16, 2014
jens-na
pushed a commit
to jens-na/jekyll
that referenced
this pull request
Jan 18, 2014
jens-na
pushed a commit
to jens-na/jekyll
that referenced
this pull request
Jan 18, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mattr- got me thinking about ways to sort pages in #1941, specifically around documentation, and I think this is a pretty cool way to do it. It further simplifies the awesome table of contents stuff that @penibelst did via 3f7dcaa, and eliminates the double content that unfortunately still existed there.
Change the data file, change the table of contents.