New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data feature to define docs index #1953

Merged
merged 1 commit into from Jan 16, 2014

Conversation

Projects
None yet
5 participants
@troyswanson
Member

troyswanson commented Jan 15, 2014

@mattr- got me thinking about ways to sort pages in #1941, specifically around documentation, and I think this is a pretty cool way to do it. It further simplifies the awesome table of contents stuff that @penibelst did via 3f7dcaa, and eliminates the double content that unfortunately still existed there.

Change the data file, change the table of contents.

@troyswanson

This comment has been minimized.

Member

troyswanson commented Jan 15, 2014

I have no idea why the build is failing on this, though. 😟

@doktorbro

This comment has been minimized.

Member

doktorbro commented Jan 15, 2014

Very nice.

The tests don’t cover the documentation. It must be something different introduced by others before your commit.

@troyswanson

This comment has been minimized.

Member

troyswanson commented Jan 15, 2014

Next up after this, using the data file to generate the "Back" and "Next" buttons instead of using the page variables.

@mattr-

This comment has been minimized.

Member

mattr- commented Jan 15, 2014

Looks fine to me. @parkr?

@ghost ghost assigned parkr Jan 15, 2014

@parkr parkr merged commit 6aa2fc0 into jekyll:master Jan 16, 2014

1 check failed

default The Travis CI build failed
Details

parkr added a commit that referenced this pull request Jan 16, 2014

jens-na pushed a commit to jens-na/jekyll that referenced this pull request Jan 18, 2014

jens-na pushed a commit to jens-na/jekyll that referenced this pull request Jan 18, 2014

@troyswanson troyswanson referenced this pull request Feb 16, 2014

Merged

Jekyll new theme redesign #2050

5 of 5 tasks complete

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.