New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Sass import #2009

Merged
merged 6 commits into from Feb 13, 2014

Conversation

Projects
None yet
3 participants
@doktorbro
Member

doktorbro commented Feb 4, 2014

As I was not sure how the Sass import feature works in Jekyll, I’ve created a new test.

I need a little help to make the broken sort test run.

@parkr

This comment has been minimized.

Member

parkr commented Feb 4, 2014

Thanks for taking care of adding this test! Definitely want this in there. Will take a look soon.

@parkr parkr self-assigned this Feb 4, 2014

@@ -131,7 +131,7 @@ def initialize(opts = {})
assert_equal 2, g["items"].size
when ""
assert g["items"].is_a?(Array), "The list of grouped items for '' is not an Array."
assert_equal 6, g["items"].size
assert_equal 8, g["items"].size

This comment has been minimized.

@doktorbro

doktorbro Feb 4, 2014

Member

Why increment by 2?

This comment has been minimized.

@parkr

parkr Feb 13, 2014

Member

The symlink stuff, I suppose!

This comment has been minimized.

@doktorbro

doktorbro Feb 13, 2014

Member

Yes, the symlink, like in the sort test.

@doktorbro

View changes

test/test_site.rb Outdated
@@ -157,7 +157,7 @@ def generate(site)
should "sort pages alphabetically" do
stub.proxy(Dir).entries { |entries| entries.reverse }
@site.process
sorted_pages = %w(.htaccess about.html bar.html coffeescript.coffee contacts.html deal.with.dots.html foo.md index.html index.html properties.html sitemap.xml symlinked-file)
sorted_pages = %w(.htaccess about.html bar.html coffeescript.coffee contacts.html deal.with.dots.html foo.md index.html index.html main.scss main.scss properties.html sitemap.xml symlinked-file)

This comment has been minimized.

@doktorbro

doktorbro Feb 4, 2014

Member

Why main.scss 2 times?

This comment has been minimized.

@parkr

parkr Feb 8, 2014

Member

Yah, that doesn't make any sense. The @import'd scss file shouldn't be in the list of pages. Did you and I both create main.scss?

This comment has been minimized.

@doktorbro

doktorbro Feb 8, 2014

Member

I get it. The symlinked-dir is linked with css directory, that contains main.scss. I’ve added the comment to the sort test.

This comment has been minimized.

@parkr

parkr Feb 13, 2014

Member

Weirrrd. They shouldn't show the page twice, though, should they? Or is main.scss being generated in 2 places because of the symlink?

@parkr parkr added the Enhancement label Feb 7, 2014

@parkr

This comment has been minimized.

Member

parkr commented Feb 13, 2014

Ready to merge?

@doktorbro

This comment has been minimized.

Member

doktorbro commented Feb 13, 2014

Ready to merge?

Yes. I’m very happy how the import feature works.

parkr added a commit that referenced this pull request Feb 13, 2014

@parkr parkr merged commit d43341f into jekyll:master Feb 13, 2014

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Feb 13, 2014

@doktorbro doktorbro deleted the doktorbro:test-sass-include branch Feb 13, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.