-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Sass import #2009
Test Sass import #2009
Conversation
Thanks for taking care of adding this test! Definitely want this in there. Will take a look soon. |
@@ -131,7 +131,7 @@ def initialize(opts = {}) | |||
assert_equal 2, g["items"].size | |||
when "" | |||
assert g["items"].is_a?(Array), "The list of grouped items for '' is not an Array." | |||
assert_equal 6, g["items"].size | |||
assert_equal 8, g["items"].size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why increment by 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The symlink stuff, I suppose!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the symlink, like in the sort test.
Ready to merge? |
Yes. I’m very happy how the import feature works. |
As I was not sure how the Sass import feature works in Jekyll, I’ve created a new test.
I need a little help to make the broken sort test run.