Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump listen dependency to latest version (2.5.0) #2086

Closed
wants to merge 2 commits into from
Closed

Bump listen dependency to latest version (2.5.0) #2086

wants to merge 2 commits into from

Conversation

benbalter
Copy link
Contributor

Because newer === better.

(Also because dependency conflicts === bad)

Surprisingly tests somehow pass. So here goes nothing...

/cc @rsanheim

@rsanheim
Copy link

Hey lets hold off on this. It actually showed some really buggy behavior for me with the latest listen with the latest guard.

@parkr
Copy link
Member

parkr commented Feb 21, 2014

@benbalter We don't test serve - didn't seem like there was a sane way to test long-polling processes.

The API has changed between 1.x and 2.x so lib/jekyll/commands/serve.rb will need to be updated. Test with bin/jekyll serve -s site until it works perfecto.

@benbalter
Copy link
Contributor Author

I tested, and it works perfectly, as long as you don't change any files. :trollface:

@parkr parkr closed this in #2097 Feb 24, 2014
@benbalter benbalter deleted the listen-2-5-0 branch February 24, 2014 23:58
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants