New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract core extensions into a Utils module #2112

Merged
merged 4 commits into from Mar 4, 2014

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Mar 4, 2014

Fixes #2111

@@ -83,7 +83,9 @@ def self.configuration(override)
config = config.read_config_files(config.config_files(override))
# Merge DEFAULTS < _config.yml < override
config = config.deep_merge(override).stringify_keys
config = Utils.hash_stringify_keys(

This comment has been minimized.

@mattr-

mattr- Mar 4, 2014

Member

Perhaps we could use stringify_hash_keys instead? It seems to read better at least. stringify_keys would also be good.

This comment has been minimized.

@parkr

parkr Mar 4, 2014

Member

Totally fine to rename the functions – stringify_hash_keys is a bit cleaner.

This comment has been minimized.

@mattr-

mattr- Mar 4, 2014

Member

I only struck through it because you already released the new version of the sass converter.

This comment has been minimized.

@parkr

parkr Mar 4, 2014

Member

We can release as many versions as we want! If it's better for future maintainability, let's switch it up. If it were manual labour and incredibly difficult, I'd say let's ignore it, but I have yet to break a sweat coding so it can't be that hard. :)

@parkr parkr added this to the 2.0 milestone Mar 4, 2014

@parkr parkr added Feature and removed Feature labels Mar 4, 2014

@parkr parkr self-assigned this Mar 4, 2014

parkr added a commit that referenced this pull request Mar 4, 2014

@parkr parkr merged commit 2985758 into master Mar 4, 2014

1 check passed

default The Travis CI build passed
Details

@parkr parkr deleted the no-core-ext branch Mar 4, 2014

parkr added a commit that referenced this pull request Mar 4, 2014

@mattr-

This comment has been minimized.

Member

mattr- commented Mar 4, 2014

❤️

@benbalter

This comment has been minimized.

Contributor

benbalter commented Mar 4, 2014

approval

lmullen added a commit to lmullen/jekyll that referenced this pull request Mar 24, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.