Extract core extensions into a Utils module #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,7 +83,9 @@ def self.configuration(override) | |||
| config = config.read_config_files(config.config_files(override)) | |||
|
|
|||
| # Merge DEFAULTS < _config.yml < override | |||
| config = config.deep_merge(override).stringify_keys | |||
| config = Utils.hash_stringify_keys( | |||
There was a problem hiding this comment.
Perhaps we could use stringify_hash_keys instead? It seems to read better at least. stringify_keys would also be good.
There was a problem hiding this comment.
Totally fine to rename the functions – stringify_hash_keys is a bit cleaner.
There was a problem hiding this comment.
I only struck through it because you already released the new version of the sass converter.
There was a problem hiding this comment.
We can release as many versions as we want! If it's better for future maintainability, let's switch it up. If it were manual labour and incredibly difficult, I'd say let's ignore it, but I have yet to break a sweat coding so it can't be that hard. :)
parkr
added a commit
that referenced
this pull request
Mar 4, 2014
parkr
added a commit
that referenced
this pull request
Mar 4, 2014
|
❤️ |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2111