New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CLI & Commands For Greater Happiness #2143

Merged
merged 2 commits into from Mar 16, 2014

Conversation

Projects
None yet
5 participants
@parkr
Member

parkr commented Mar 13, 2014

  • Commands know how to initialize themselves
  • External plugins can now ship commands if they want
  • Fix infinite loop when jekyll is run w/o arguments

Fixes #2124.

p.action do |args, options|
if args.empty?
p.go(["-h"])
puts p

This comment has been minimized.

@parkr

parkr Mar 16, 2014

Member

@imathis This is how you print the command help. The p.go(['-h']) just results in a big ol' loop that never ends which sucks. If you just print the program, it'll print out the help message as you'd expect.

@parkr

This comment has been minimized.

Member

parkr commented Mar 16, 2014

What say you, @mattr-?

@parkr parkr added this to the 2.0 milestone Mar 16, 2014

@parkr parkr added the Enhancement label Mar 16, 2014

parkr added a commit that referenced this pull request Mar 16, 2014

@parkr parkr merged commit a581bc1 into master Mar 16, 2014

1 check passed

default The Travis CI build passed
Details

@parkr parkr deleted the fix-cli branch Mar 16, 2014

parkr added a commit that referenced this pull request Mar 16, 2014

lmullen added a commit to lmullen/jekyll that referenced this pull request Mar 24, 2014

@omerbaror4

This comment has been minimized.

omerbaror4 commented on 8e9644a May 29, 2014

i own valerian bank

@pathawks

This comment has been minimized.

Member

pathawks commented on lib/jekyll/commands/build.rb in e746b3b Dec 31, 2015

This Private is never enforced with the private keyword, is it?

This comment has been minimized.

Member

parkr replied Jan 4, 2016

No, it is not. This is old, anyway.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.