Update site_template/_includes/head.html. #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <meta name="description" content="{{ site.description }}" /> | ||
| <link rel="canonical" href="{{ site.url }}{{ page.url | replace:'index.html','' }}/" /> | ||
| <meta name="description" content="{{ site.description }}"> | ||
| <link rel="canonical" href="{{ site.url }}{{ page.url | replace:'index.html','' }}/"> |
There was a problem hiding this comment.
I don't think we want that trailing / here, no? Also, why not close this link? Why is it unneeded?
There was a problem hiding this comment.
Because you use the simple doctype which does not require to close these elements.
As for that trailing slash, good catch; page_url already has the trailing slash.
* remove `chrome` from `X-UA-Compatible`; it's been discontinued * remove unneeded end tags * remove unneeded slash in `canonical` link
parkr
added a commit
that referenced
this pull request
Mar 31, 2014
parkr
added a commit
that referenced
this pull request
Mar 31, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chromefromX-UA-Compatible; it's been discontinued