New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site_template/_includes/head.html. #2186

Merged
merged 1 commit into from Mar 31, 2014

Conversation

Projects
None yet
3 participants
@XhmikosR
Contributor

XhmikosR commented Mar 31, 2014

  • remove chrome from X-UA-Compatible; it's been discontinued
  • remove unneeded end tags
@parkr

View changes

lib/site_template/_includes/head.html Outdated
<meta name="description" content="{{ site.description }}" />
<link rel="canonical" href="{{ site.url }}{{ page.url | replace:'index.html','' }}/" />
<meta name="description" content="{{ site.description }}">
<link rel="canonical" href="{{ site.url }}{{ page.url | replace:'index.html','' }}/">

This comment has been minimized.

@parkr

parkr Mar 31, 2014

Member

I don't think we want that trailing / here, no? Also, why not close this link? Why is it unneeded?

This comment has been minimized.

@XhmikosR

XhmikosR Mar 31, 2014

Contributor

Because you use the simple doctype which does not require to close these elements.

As for that trailing slash, good catch; page_url already has the trailing slash.

Update site_template/_includes/head.html.
* remove `chrome` from `X-UA-Compatible`; it's been discontinued
* remove unneeded end tags
* remove unneeded slash in `canonical` link

parkr added a commit that referenced this pull request Mar 31, 2014

@parkr parkr merged commit 8cfa938 into jekyll:master Mar 31, 2014

@XhmikosR XhmikosR deleted the XhmikosR:site_template branch Mar 31, 2014

parkr added a commit that referenced this pull request Mar 31, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.