Improve docs feed #2192
Improve docs feed #2192
Conversation
| <description><![CDATA[ {{ post.content }} ]]></description> | ||
| <title>{{ post.title | xml_escape}}</title> | ||
| <link>http://jekyllrb.com{{ post.url }}</link> | ||
| <pubDate>{{ post.date | date: "%a, %d %b %Y %H:%M:%S %z" }}</pubDate> |
There was a problem hiding this comment.
Perhaps you can use the date_to_rfc822 filter here instead of this long date format string.
There was a problem hiding this comment.
Yeah makes sense. I didn't touch the date stuff :)
There was a problem hiding this comment.
Fair enough. Might as well change it up to increase readability, though. There are a couple more instances that can be updated too, if you don't mind. (Line 18 and 19)
There was a problem hiding this comment.
Added it, thanks @troyswanson
|
👍 Looks good! 👏 |
|
Unfortunately, we can't make the feed valid since GitHub Pages doesn't allow us to use custom plugins... http://validator.w3.org/feed/check.cgi?url=http%3A%2F%2Fjekyllrb.com%2Ffeed.xml I personally use this. Not sure if there's another better or simpler way to do it. |
|
I'm confused. It says it is valid for me. |
|
Hmm I should have said, the feed doesn't have any warnings I suppose. |
|
Meh, if it's valid, it's valid! 👍 |
|
@XhmikosR Would you mind doing a quick rebase? ❤️ |
* add `generator` property * add image property * use `xml_escape` instead of `![CDATA]` * use `date_to_rfc822` instead of the date format string (thanks @troyswanson!) * fix self reference url * switch to `isPermaLink` for the `guid`
|
@parkr: done! |
@parkr: let me know if you need me to make any changes.
I personally find it useful to have the
generatorproperty, but it's just cosmetic.Also for the feed image, Firefox shows it right, Chrome doesn't. Keep in mind that these must be in
gh-pagesfor the image link to work :)I used https://github.com/jekyll/jekyll-logo/blob/master/jekyll-logo-light-transparent.png and resized it to 144x73 since the specs say that the maximum image width is 144px.