@maul-esel's frontmatter defaults work, rebased #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for example possible for layout defaults to take effect.
The Page#path or Post#path can be overriden by by a frontmatter setting. This causes path-based frontmatter default detection to fail. Add test to demonstrate this and fix it.
Before, the bottom-most default set had highest precedence. Instead, now the set with a longer i.e. more specific path has precedence and sets with a type setting have precedence over those without one. In case of equal precedence the bottom-most still wins.
…yll into maul-esel-frontmatter-defaults * 'frontmatter-defaults' of git://github.com/maul-esel/jekyll: move self.type to convertible oops, fix minor indentation quirk document frontmatter defaults precedence adjust frontmatter defaults precedence handling change cucumber feature to test for precedence too fix frontmatter defaults for custom paths more robust cucumber features fix slash handling for paths move cucumber features to own file fix minor docs quirk improve path checking, now using Pathname instead of regex Add site documentation for the new feature add inline code docs improve validation code fix for Ruby 1.8 Add basic cucumber features for frontmatter defaults Retrieve frontmatter defaults when retrieved internally make frontmatter defaults available to liquid add a class `FrontmatterDefaults` for handling of frontmatter defaults Add a method to retrieve type to post, page and draft Conflicts: lib/jekyll.rb lib/jekyll/convertible.rb lib/jekyll/core_ext.rb lib/jekyll/page.rb lib/jekyll/post.rb
|
The tests are failing because - and this is just a guess - we stopped allowing |
Use `page.description` in the cucumber feature instead. `page.name` isn't overridable anymore.
|
I've updated the cucumber scenarios to not use |
|
Thank you!! Given that |
parkr
added a commit
that referenced
this pull request
Apr 22, 2014
parkr
added a commit
that referenced
this pull request
Apr 22, 2014
cben
added a commit
to cben/sandbox
that referenced
this pull request
Apr 30, 2014
jekyll/jekyll#2205 probably not in github pages yet?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #1527.
/cc @maul-esel