Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Travis bug #2290

Merged
merged 2 commits into from May 3, 2014

Conversation

Projects
None yet
3 participants
@doktorbro
Copy link
Member

doktorbro commented May 3, 2014

Switch Ruby version from 2.1.0 to 2.1 until fixed travis-ci/travis-ci#2220

@parkr

This comment has been minimized.

Copy link
Member

parkr commented May 3, 2014

If we're allowing failures in 2.1, why also modify the rvm specification to 2.1 from 2.1.0? Why not just allow failures in 2.1.0?

@doktorbro

This comment has been minimized.

Copy link
Member Author

doktorbro commented May 3, 2014

@parkr I found this decision in others people commits. Ruby 2.1.1, which is chosen if you set 2.1, has a regretion, so they don’t trust 2.1. Jekyll doesn’t fail at 2.1.1.

Should I switch the version back and allow failures for 2.1.0? Or just leave 2.1 without allowing failures?

parkr added a commit that referenced this pull request May 3, 2014

@parkr parkr merged commit 98f9902 into jekyll:master May 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@@ -4,7 +4,7 @@ install:
- script/rebund download
- travis_retry bundle install --path vendor/bundle
rvm:
- 2.1.0
- 2.1.1

This comment has been minimized.

@doktorbro

doktorbro May 3, 2014

Author Member

During the latest build environment updates Travis switched Ruby 2.1.0 to 2.1.1 at 04:00 UTC on the 30th of April. I think Jekyll can switch to Ruby 2.1.1 too. It’s not a workaround anymore, but a regular upgrade.

parkr added a commit that referenced this pull request May 3, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.