New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Russian and Hebrew sort #2384

Merged
merged 3 commits into from May 11, 2014

Conversation

Projects
None yet
4 participants
@doktorbro
Member

doktorbro commented May 10, 2014

Based on #2379 (comment) from @envygeeks

@doktorbro

This comment has been minimized.

Member

doktorbro commented May 10, 2014

@envygeeks Looks like the test crashes on Ruby 1.9.3 only. Newer versions can handle non-ascii sorting. Can you fix it in 1.9.3?

@ixti

This comment has been minimized.

Member

ixti commented May 10, 2014

@penibelst test failed by some different reason (as far as i see) and just needed to be restarted on travis. Other than that I would also propose to test ascii+utf8 edge:

assert_equal ["_вуз", "вуз", "вуз_"], @filter.sort(["вуз_", "_вуз", "вуз"])
@doktorbro

This comment has been minimized.

Member

doktorbro commented May 10, 2014

test failed by some different reason (as far as i see) and just needed to be restarted on travis.

No, this is wrong. The test fails on my local machine with Ruby 1.9.3 too.

@ixti

This comment has been minimized.

Member

ixti commented May 11, 2014

Ah. indeed. Well the issue is not with spec actually anyway :)) Use following patch to fix it:

From f0a1c39bf82318e6150c2f8d2e05f3efe86c8c1f Mon Sep 17 00:00:00 2001
From: Aleksey V Zapparov <ixti@member.fsf.org>
Date: Sun, 11 May 2014 02:11:36 +0200
Subject: [PATCH] Fix UTF-8 related specs

---
 test/test_filters.rb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/test/test_filters.rb b/test/test_filters.rb
index 9537377..e56a88c 100644
--- a/test/test_filters.rb
+++ b/test/test_filters.rb
@@ -1,3 +1,5 @@
+# coding: utf-8
+
 require 'helper'

 class TestFilters < Test::Unit::TestCase
-- 
2.0.0.rc0
@doktorbro

This comment has been minimized.

Member

doktorbro commented May 11, 2014

Use following patch to fix it:

Done. Now it works.

parkr added a commit that referenced this pull request May 11, 2014

@parkr parkr merged commit c68d83b into jekyll:master May 11, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 11, 2014

@doktorbro doktorbro deleted the doktorbro:test-sort-utf8 branch May 11, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.