New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post date #2394

Merged
merged 1 commit into from May 11, 2014

Conversation

Projects
None yet
3 participants
@doktorbro
Member

doktorbro commented May 11, 2014

Instead of changing the reference to the post like in #2367, I prefer to fix the date of the post itself. Note that the link http://jekyllrb.com/news/2013/05/05/jekyll-1-0-0-released/ doesn’t change.

And I changed the time zone to Los Angeles like @parkr suggested in #2367 (comment).

@parkr

This comment has been minimized.

Member

parkr commented May 11, 2014

I like the change to _config.yml, but not to the post. Having the exact time is important to me and keeps the time consistent across all timezones, such that it occurred at the same moment in time (not shifted by timezone).

@doktorbro

This comment has been minimized.

Member

doktorbro commented May 11, 2014

@parkr Post changes are reverted. The docs are in Los Angeles now.

@parkr

This comment has been minimized.

Member

parkr commented May 11, 2014

Cool, thanks. Can you please squish those down into 1 commit?

@doktorbro

This comment has been minimized.

Member

doktorbro commented May 11, 2014

Can you please squish those down into 1 commit?

Done.

parkr added a commit that referenced this pull request May 11, 2014

@parkr parkr merged commit 8068702 into jekyll:master May 11, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 11, 2014

@doktorbro doktorbro deleted the doktorbro:fix-dates branch May 12, 2014

@parkr parkr referenced this pull request May 12, 2014

Closed

Fix wrong post reference. #2367

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.