override EXCERPT_ATTRIBUTES_FOR_LIQUID #2408

Merged
merged 1 commit into from May 15, 2014

Conversation

Projects
None yet
3 participants
@quinn
Contributor

quinn commented May 14, 2014

Allow EXCERPT_ATTRIBUTES_FOR_LIQUID to be overridden by inheriting class. Right now will always reference Jekyll::Post::EXCERPT_ATTRIBUTES_FOR_LIQUID. This is already being used in the codebase for ATTRIBUTES_FOR_LIQUID.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 14, 2014

Member

I'm 👍 on this. Can you please add a test?

Member

parkr commented May 14, 2014

I'm 👍 on this. Can you please add a test?

override EXCERPT_ATTRIBUTES_FOR_LIQUID
Allow EXCERPT_ATTRIBUTES_FOR_LIQUID to be overridden by inheriting class. Right now will always reference Jekyll::Post::EXCERPT_ATTRIBUTES_FOR_LIQUID. This is already being used in the codebase for ATTRIBUTES_FOR_LIQUID.
@quinn

This comment has been minimized.

Show comment
Hide comment
@quinn

quinn May 14, 2014

Contributor

Added tests... I didn't want to add anything outside of the tests themselves, hopefully that's ok.

Contributor

quinn commented May 14, 2014

Added tests... I didn't want to add anything outside of the tests themselves, hopefully that's ok.

parkr added a commit that referenced this pull request May 15, 2014

@parkr parkr merged commit ba905a2 into jekyll:master May 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 15, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.