Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent table from extending parent width #2424

Merged
merged 1 commit into from May 20, 2014

Conversation

Projects
None yet
3 participants
@kleinfreund
Copy link
Contributor

kleinfreund commented May 19, 2014

The table containing the Permalink style examples in the docs extends the width of the content container.

Screenshot: layout quirk in permalink docs

The solution I propose is a bit dirty, because I remove permalink: in the left column to make the table fit.

Screenshot: fixed layout quirk

Another way would be using white-space: normal; for code inside tables. That would lead to ugly line-breaks within the code.

What do you think?

Philipp Rudloff
Prevent table from extending parent width
The table containing the _Permalink style examples_ [in the docs](http://jekyllrb.com/docs/permalinks/#permalink-style-examples) extends the width of the content container.

The solution I propose is a bit dirty, because I remove `permalink: ` in the left column to make the table fit.

Another way would be using `white-space: normal;` for code inside tables. That would lead to _ugly_ line-breaks within the code.

What do you think?
@parkr

This comment has been minimized.

Copy link
Member

parkr commented May 19, 2014

Yeah, this is OK.

@cobyism, is there a better way to do this that you can think of?

parkr added a commit that referenced this pull request May 20, 2014

@parkr parkr merged commit d3f9427 into jekyll:master May 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 20, 2014

@kleinfreund kleinfreund deleted the kleinfreund:patch-2 branch May 21, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.