New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing help command in deprecation warning #2457

Merged
merged 1 commit into from May 27, 2014

Conversation

Projects
None yet
3 participants
@marcransome
Contributor

marcransome commented May 27, 2014

There appears to be a long-standing inconsistency in the deprecation warning regarding how to use the help command:

Deprecation: Jekyll now uses subcommands instead of just switches. Run `jekyll help' to find out more.

Leading to much hilarity:

$ jekyll help
Invalid command. Use --help for more information

Correct me if I'm wrong, but it appears that the intention was to retain the --help and --version flags, and to assume that anything else is a subcommand:

if args.size > 0 && args.first =~ /^--/ && !%w[--help --version].include?(args.first)
    ...
end
@parkr

This comment has been minimized.

Member

parkr commented May 27, 2014

You're absolutely right! Thank you!

parkr added a commit that referenced this pull request May 27, 2014

@parkr parkr merged commit ba5922f into jekyll:master May 27, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 27, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.