Collections with dots #2552
Merged
Collections with dots #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,15 +17,15 @@ def fixture_site(overrides = {}) | |||
| end | |||
|
|
|||
| should "sanitize the label name" do | |||
| assert_equal @collection.label, "etcpassword" | |||
| assert_equal @collection.label, "....etcpassword" | |||
There was a problem hiding this comment.
@gregose If a collection label allows "." but not "/", is it still safe?
There was a problem hiding this comment.
Should be fine. Where ever this is used, the full canonicalized path should still be checked before file access.
parkr
added a commit
that referenced
this pull request
Jun 28, 2014
parkr
added a commit
that referenced
this pull request
Jun 28, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2548.