Use .scss for site_template styles. #2667

Merged
merged 1 commit into from Aug 1, 2014

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Jul 31, 2014

Why not? 馃槃

@parkr parkr added the Enhancement label Jul 31, 2014

@kleinfreund

This comment has been minimized.

Show comment
Hide comment
@kleinfreund

kleinfreund Aug 1, 2014

Contributor

Should I take a stab at doing some Sass magic there? Currently it's plain CSS.

Contributor

kleinfreund commented Aug 1, 2014

Should I take a stab at doing some Sass magic there? Currently it's plain CSS.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 1, 2014

Member

If you'd like to! It should remain simple and easy-to-understand, but it could certainly use some improvement. :)

Member

parkr commented Aug 1, 2014

If you'd like to! It should remain simple and easy-to-understand, but it could certainly use some improvement. :)

parkr added a commit that referenced this pull request Aug 1, 2014

@parkr parkr merged commit 96b1778 into master Aug 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@parkr parkr deleted the use-page branch Aug 1, 2014

parkr added a commit that referenced this pull request Aug 1, 2014

@kleinfreund

This comment has been minimized.

Show comment
Hide comment
@kleinfreund

kleinfreund Aug 2, 2014

Contributor

My plans were to only rewrite the file in SCSS manner (nesting CSS rule declarations, etc.). However if we really want to take this step I wonder if we should not do a bit more.

  • Use main.scss as an import file for:
    • a _typography.scss partial for typographic styles鈥
    • 鈥nd a _layout.scss partial for the rest 鈥 the layout rules
  • Utilize variables where possible/necessary (e.g. when the same value reappears in the styles multiple times)

This would emphasize why it is a good idea to use Sass and how some basic strategies of using it look like.

What do you think?

Contributor

kleinfreund commented Aug 2, 2014

My plans were to only rewrite the file in SCSS manner (nesting CSS rule declarations, etc.). However if we really want to take this step I wonder if we should not do a bit more.

  • Use main.scss as an import file for:
    • a _typography.scss partial for typographic styles鈥
    • 鈥nd a _layout.scss partial for the rest 鈥 the layout rules
  • Utilize variables where possible/necessary (e.g. when the same value reappears in the styles multiple times)

This would emphasize why it is a good idea to use Sass and how some basic strategies of using it look like.

What do you think?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 2, 2014

Member

Great idea!

Member

parkr commented Aug 2, 2014

Great idea!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.