Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .scss for site_template styles. #2667

Merged
merged 1 commit into from
Aug 1, 2014
Merged

Use .scss for site_template styles. #2667

merged 1 commit into from
Aug 1, 2014

Conversation

parkr
Copy link
Member

@parkr parkr commented Jul 31, 2014

Why not? 😄

@kleinfreund
Copy link

Should I take a stab at doing some Sass magic there? Currently it's plain CSS.

@parkr
Copy link
Member Author

parkr commented Aug 1, 2014

If you'd like to! It should remain simple and easy-to-understand, but it could certainly use some improvement. :)

parkr added a commit that referenced this pull request Aug 1, 2014
@parkr parkr merged commit 96b1778 into master Aug 1, 2014
@parkr parkr deleted the use-page branch August 1, 2014 17:17
parkr added a commit that referenced this pull request Aug 1, 2014
@kleinfreund
Copy link

My plans were to only rewrite the file in SCSS manner (nesting CSS rule declarations, etc.). However if we really want to take this step I wonder if we should not do a bit more.

  • Use main.scss as an import file for:
    • a _typography.scss partial for typographic styles…
    • …and a _layout.scss partial for the rest – the layout rules
  • Utilize variables where possible/necessary (e.g. when the same value reappears in the styles multiple times)

This would emphasize why it is a good idea to use Sass and how some basic strategies of using it look like.

What do you think?

@parkr
Copy link
Member Author

parkr commented Aug 2, 2014

Great idea!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants