Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore subfolders in the _posts folder. #2705

Merged
merged 3 commits into from Aug 7, 2014

Conversation

@bcomnes
Copy link
Contributor

@bcomnes bcomnes commented Aug 6, 2014

This reverts only the changes made in #2633

It was performed by running git revert -m 1 18c033dc5c00b2ce0b3528cb310bf3988377e39f and manually solving the merge conflict to preserve later changes.

The merge that is reverted assigned categories to posts
based on the subfolders in the _posts directory and 
was merged under the understanding that it was fixing a bug.

Subfolders in the _posts directory should not assign 
metadata information to posts at this point in time and 
was not a bug.
@bcomnes
Copy link
Contributor Author

@bcomnes bcomnes commented Aug 6, 2014

I only reverted the changes from the original merge. Are there any subsequent changes due to later changes that need to be made?

assert_equal "cat2", post.categories[0]
assert_equal "cat3", post.categories[1]
end

This comment has been minimized.

@parkr

parkr Aug 6, 2014
Member

Can we keep this test and ensure that the categories are not added?

This comment has been minimized.

@bcomnes

bcomnes Aug 6, 2014
Author Contributor

Good idea. I can work on that.

@bcomnes

This comment has been minimized.

Copy link
Owner Author

@bcomnes bcomnes commented on test/test_post.rb in d0ac491 Aug 6, 2014

What does 'topics' refer to? Should this be testing the slug from the filename which is named topical-post?

@bcomnes
Copy link
Contributor Author

@bcomnes bcomnes commented Aug 6, 2014

Whelp... that didn't work. Let me try again, locally.

@parkr
Copy link
Member

@parkr parkr commented Aug 6, 2014

Whelp... that didn't work. Let me try again, locally.

Did you try adding self.categories ||= [] in the initialize method, toward the top? Maybe right after the top 4 lines.

@bcomnes
Copy link
Contributor Author

@bcomnes bcomnes commented Aug 6, 2014

I already just added some test categories to populate the category array. Would you prefer I do it the other way?

@parkr
Copy link
Member

@parkr parkr commented Aug 7, 2014

This will work – I'll merge this and push up a fix for how categories are added after. Thanks!

parkr added a commit that referenced this pull request Aug 7, 2014
@parkr parkr merged commit a0b30a9 into jekyll:master Aug 7, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
parkr added a commit that referenced this pull request Aug 7, 2014
@bcomnes
Copy link
Contributor Author

@bcomnes bcomnes commented Aug 7, 2014

👍 🍺

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.