Ignore subfolders in the _posts folder. #2705

Merged
merged 3 commits into from Aug 7, 2014

Conversation

Projects
None yet
3 participants
@bcomnes
Contributor

bcomnes commented Aug 6, 2014

This reverts only the changes made in #2633

It was performed by running git revert -m 1 18c033dc5c00b2ce0b3528cb310bf3988377e39f and manually solving the merge conflict to preserve later changes.

Reverts 18c033d
The merge that is reverted assigned categories to posts
based on the subfolders in the _posts directory and 
was merged under the understanding that it was fixing a bug.

Subfolders in the _posts directory should not assign 
metadata information to posts at this point in time and 
was not a bug.
@bcomnes

This comment has been minimized.

Show comment
Hide comment
@bcomnes

bcomnes Aug 6, 2014

Contributor

I only reverted the changes from the original merge. Are there any subsequent changes due to later changes that need to be made?

Contributor

bcomnes commented Aug 6, 2014

I only reverted the changes from the original merge. Are there any subsequent changes due to later changes that need to be made?

test/test_post.rb
- assert_equal "cat2", post.categories[0]
- assert_equal "cat3", post.categories[1]
- end
-

This comment has been minimized.

@parkr

parkr Aug 6, 2014

Member

Can we keep this test and ensure that the categories are not added?

@parkr

parkr Aug 6, 2014

Member

Can we keep this test and ensure that the categories are not added?

This comment has been minimized.

@bcomnes

bcomnes Aug 6, 2014

Contributor

Good idea. I can work on that.

@bcomnes

bcomnes Aug 6, 2014

Contributor

Good idea. I can work on that.

@bcomnes

This comment has been minimized.

Show comment
Hide comment
@bcomnes

bcomnes Aug 6, 2014

Owner

What does 'topics' refer to? Should this be testing the slug from the filename which is named topical-post?

What does 'topics' refer to? Should this be testing the slug from the filename which is named topical-post?

@bcomnes

This comment has been minimized.

Show comment
Hide comment
@bcomnes

bcomnes Aug 6, 2014

Contributor

Whelp... that didn't work. Let me try again, locally.

Contributor

bcomnes commented Aug 6, 2014

Whelp... that didn't work. Let me try again, locally.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 6, 2014

Member

Whelp... that didn't work. Let me try again, locally.

Did you try adding self.categories ||= [] in the initialize method, toward the top? Maybe right after the top 4 lines.

Member

parkr commented Aug 6, 2014

Whelp... that didn't work. Let me try again, locally.

Did you try adding self.categories ||= [] in the initialize method, toward the top? Maybe right after the top 4 lines.

@bcomnes

This comment has been minimized.

Show comment
Hide comment
@bcomnes

bcomnes Aug 6, 2014

Contributor

I already just added some test categories to populate the category array. Would you prefer I do it the other way?

Contributor

bcomnes commented Aug 6, 2014

I already just added some test categories to populate the category array. Would you prefer I do it the other way?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 7, 2014

Member

This will work – I'll merge this and push up a fix for how categories are added after. Thanks!

Member

parkr commented Aug 7, 2014

This will work – I'll merge this and push up a fix for how categories are added after. Thanks!

@parkr parkr merged commit a0b30a9 into jekyll:master Aug 7, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Aug 7, 2014

@bcomnes

This comment has been minimized.

Show comment
Hide comment
@bcomnes

bcomnes Aug 7, 2014

Contributor

👍 🍺

Contributor

bcomnes commented Aug 7, 2014

👍 🍺

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.