New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call #to_liquid before calling #to_json in jsonify filter. #2729

Merged
merged 1 commit into from Aug 12, 2014

Conversation

Projects
None yet
2 participants
@parkr
Member

parkr commented Aug 12, 2014

I was working on usds/playbook#7 (comment) and remembered that the jsonify filter didn't call #to_liquid before turning it into json.

Another option is to alias #to_json to #to_liquid in Document, and Convertible.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr
Member

parkr commented Aug 12, 2014

@parkr parkr merged commit 7b9d392 into master Aug 12, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@parkr parkr deleted the to_liquid_before_jsonify branch Aug 12, 2014

parkr added a commit that referenced this pull request Aug 12, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.