Render Liquid in CoffeeScript files

[kansaichris]

Closes #2792. Is it really this simple?

Incidentally, it seems a bit odd for render_with_liquid? to always return true, but I guess it's nice to keep the function around just in case we need to disable Liquid for some other file type in the future.

/cc @gjtorikian and @parkr for review 🙇

[kansaichris]

Whoops, forgot to fix the Cucumber tests. I'll get to that as soon as I can. 😊

[parkr]

LGTM 😄 @gjtorikian, can I get a 👍 or 👎 ?

[parkr]

@kansaichris would you also please add docs to site/_docs/assets.md? A big warning note about liquid and template languages (like mustache) would be great. There may also be a note about coffeescript not being rendered w/Liquid that can be removed.

Thank you! ✨

[gjtorikian]

Yeah, adding docs would be huge.

[kansaichris]

Here's the CI build error, for what it's worth:

features/drafts.feature:16  Scenario: Don't preview a draft ......There was an error highlighting your code: 
---
---
// start content
.my-definition
  font-size: 1.2em 
While attempting to convert the above code, Pygments.rb returned an unacceptable value. 
This is usually a timeout problem solved by running `jekyll build` again. 
  Liquid Exception: Pygments.rb returned an unacceptable value when attempting to highlight some code. in _docs/assets.md

[kansaichris]

would you also please add docs to site/_docs/assets.md?

Done. 😄

@parkr For future reference, do you prefer documentation updates to be submitted in the same pull request as the affected code or separately?

[parkr]

@parkr For future reference, do you prefer documentation updates to be submitted in the same pull request as the affected code or separately?

I prefer documentation updates to be submitted in the same pull request. 😄 Check out the first line of CONTRIBUTING.markdown.

[parkr]

✨

[kansaichris]

Check out the first line of CONTRIBUTING.markdown.

How could I have missed that. 😩

Should I add anything else here, or does this look like it's good to go?

[parkr]

Should I add anything else here, or does this look like it's good to go?

Looks good to me! 😄

[kansaichris]

@parkr Could I get a merge, or are we waiting on @gjtorikian? 😉

[gjtorikian]

I have nothing to do! I can't merge it.

[parkr]

I just wanted a 👍 or 👎 from Garen haha it's cool man, I'll merge tonight.

[gjtorikian]

👍 😁 all this process!

[parkr]

Sorrryyyyy!!

[kansaichris]

Thanks @parkr! ❤️