Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require gems in :jekyll_plugins group in a Gemfile in unsafe mode. #2865

Merged
merged 7 commits into from
Nov 6, 2014

Conversation

parkr
Copy link
Member

@parkr parkr commented Sep 1, 2014

Means you don't need to add it to your _config.yml under gems but only when running in unsafe more.

I need a test for this. Plz.

Replaces #1658. /cc @imathis

@parkr
Copy link
Member Author

parkr commented Oct 17, 2014

👍

@parkr parkr self-assigned this Oct 17, 2014
@parkr parkr added the feature label Oct 17, 2014
@parkr parkr added this to the 3.0 milestone Oct 17, 2014
@parkr parkr force-pushed the some-kind-of-bundler-thingy branch from 98a7c81 to 68365c1 Compare October 22, 2014 03:06
@parkr parkr mentioned this pull request Nov 5, 2014
4 tasks
@parkr
Copy link
Member Author

parkr commented Nov 5, 2014

I'd like more tests for this and I'd like to see the require happen before the Mercenary.program is created in the binary too so commands can be injected/modified.

@parkr parkr modified the milestones: 2.5, 3.0 Nov 5, 2014
@parkr parkr force-pushed the some-kind-of-bundler-thingy branch from b34e857 to 519b60d Compare November 6, 2014 02:39
@parkr parkr merged commit 13bb736 into master Nov 6, 2014
@parkr parkr deleted the some-kind-of-bundler-thingy branch November 6, 2014 06:01
parkr added a commit that referenced this pull request Nov 6, 2014
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants