New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more docs on `include_relative` #2884

Merged
merged 3 commits into from Sep 9, 2014

Conversation

Projects
None yet
3 participants
@gjtorikian
Member

gjtorikian commented Sep 8, 2014

Well, more docs, and one more test, to ensure that include_relative ../<path> really truly does not work.

gjtorikian added some commits Sep 8, 2014

Update include_relative tests
This verifies you can’t go “up” in the include
You won't need to place your included content within the `_includes` directory. Instead,
the inclusion is specifically relative to the file where the tag is being used. For example,
if `_posts/2014-09-03-my-file.markdown` uses the `include_relative` tag, the included file
must be within the `_posts` directory, or one of it's subdirectories. You cannot include

This comment has been minimized.

@parkr

parkr Sep 8, 2014

Member

Technically they should be allowed to go as high up as source, but this is probably better coding practice.

@parkr

parkr Sep 8, 2014

Member

Technically they should be allowed to go as high up as source, but this is probably better coding practice.

Set tag name as ivar
This lets us use just one syntax_example method for both classes.
@gjtorikian

This comment has been minimized.

Show comment
Hide comment
@gjtorikian

gjtorikian Sep 8, 2014

Member

I don't have the power to, because I'm not the owner, but it looks like Travis barfed on one set of tests and needs a restart. All other builds went green.

Member

gjtorikian commented Sep 8, 2014

I don't have the power to, because I'm not the owner, but it looks like Travis barfed on one set of tests and needs a restart. All other builds went green.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 8, 2014

Member

G'restarted. Also LOL @ "Travis barfed" 😂

Member

parkr commented Sep 8, 2014

G'restarted. Also LOL @ "Travis barfed" 😂

parkr added a commit that referenced this pull request Sep 9, 2014

@parkr parkr merged commit 4fb6e1c into jekyll:master Sep 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Sep 9, 2014

@gjtorikian gjtorikian deleted the gjtorikian:improve-docs-for-include-relative branch Sep 9, 2014

@awolfe76 awolfe76 referenced this pull request Oct 3, 2014

Closed

Relativity in Layouts #2900

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.