Add some more docs on include_relative
#2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This verifies you can’t go “up” in the include
| @@ -30,6 +28,10 @@ def initialize(tag_name, markup, tokens) | |||
| validate_params if @params | |||
| end | |||
|
|
|||
| def syntax_example | |||
| "{% include file.ext param='value' param2='value' %}" | |||
There was a problem hiding this comment.
why not
"{% #{tag_name} file.ext param='value' param2='value' %}"? Just have to ensure tag_name (or @tag_name) is set properly in initialize and you're goooood to go. No duplication!
This lets us use just one syntax_example method for both classes.
|
I don't have the power to, because I'm not the owner, but it looks like Travis barfed on one set of tests and needs a restart. All other builds went green. |
|
G'restarted. Also LOL @ "Travis barfed" 😂 |
parkr
added a commit
that referenced
this pull request
Sep 9, 2014
parkr
added a commit
that referenced
this pull request
Sep 9, 2014
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, more docs, and one more test, to ensure that
include_relative ../<path>really truly does not work.