Removed github-pages warning about singular default types #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
added a commit
that referenced
this pull request
Sep 13, 2014
|
Thanks! |
parkr
added a commit
that referenced
this pull request
Sep 13, 2014
|
Heh, I was just about to fix this myself. I don't think the change deployed to GitHub Pages. |
|
Uh oh. I only tested the gem locally. I'll test it out in a sec |
|
@gjtorikian I'm pretty sure this is working live on GH at least by now. The following default config works on my site: And my gh-pages builds are reporting jekyll 2.3.0: |
|
Oh, it's live on GitHub, I mean that jekyllrb.com hasn't updated yet. Except now it has. So.... 💻 ❓ |
|
Yay communication! I pushed the site yesterday I think. Sorry for the delay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... now that gh-pages is running 2.3.0