New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed github-pages warning about singular default types #2919

Merged
merged 1 commit into from Sep 13, 2014

Conversation

Projects
None yet
4 participants
@bcomnes
Contributor

bcomnes commented Sep 13, 2014

... now that gh-pages is running 2.3.0

parkr added a commit that referenced this pull request Sep 13, 2014

@parkr parkr merged commit 7cf64b6 into jekyll:master Sep 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 13, 2014

Member

Thanks!

Member

parkr commented Sep 13, 2014

Thanks!

parkr added a commit that referenced this pull request Sep 13, 2014

@gjtorikian

This comment has been minimized.

Show comment
Hide comment
@gjtorikian

gjtorikian Sep 14, 2014

Member

Heh, I was just about to fix this myself. I don't think the change deployed to GitHub Pages.

Member

gjtorikian commented Sep 14, 2014

Heh, I was just about to fix this myself. I don't think the change deployed to GitHub Pages.

@bcomnes

This comment has been minimized.

Show comment
Hide comment
@bcomnes

bcomnes Sep 14, 2014

Contributor

Uh oh. I only tested the gem locally. I'll test it out in a sec

Contributor

bcomnes commented Sep 14, 2014

Uh oh. I only tested the gem locally. I'll test it out in a sec

@bcomnes

This comment has been minimized.

Show comment
Hide comment
@bcomnes

bcomnes Sep 15, 2014

Contributor

@gjtorikian I'm pretty sure this is working live on GH at least by now. The following default config works on my site:
https://github.com/bcomnes/bcomnes.github.io/blob/master/_config.yml#L31

And my gh-pages builds are reporting jekyll 2.3.0:
http://bret.io/about/

Contributor

bcomnes commented Sep 15, 2014

@gjtorikian I'm pretty sure this is working live on GH at least by now. The following default config works on my site:
https://github.com/bcomnes/bcomnes.github.io/blob/master/_config.yml#L31

And my gh-pages builds are reporting jekyll 2.3.0:
http://bret.io/about/

@gjtorikian

This comment has been minimized.

Show comment
Hide comment
@gjtorikian

gjtorikian Sep 15, 2014

Member

Oh, it's live on GitHub, I mean that jekyllrb.com hasn't updated yet.

Except now it has. So.... 💻

Member

gjtorikian commented Sep 15, 2014

Oh, it's live on GitHub, I mean that jekyllrb.com hasn't updated yet.

Except now it has. So.... 💻

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 15, 2014

Member

Yay communication! I pushed the site yesterday I think. Sorry for the delay.

Member

parkr commented Sep 15, 2014

Yay communication! I pushed the site yesterday I think. Sorry for the delay.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.