Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to the watch command in the docs #2954

Merged
merged 3 commits into from
Sep 27, 2014
Merged

Remove references to the watch command in the docs #2954

merged 3 commits into from
Sep 27, 2014

Conversation

chrisfinazzo
Copy link
Contributor

As of 2.4, serve happens automatically every time you make a build. If it's no longer in the gem as a separate feature, this can be removed.

Thoughts?

@chrisfinazzo chrisfinazzo changed the title Remove references to the watch command in the sample Remove references to the watch command in the docs Sep 26, 2014
@@ -46,9 +46,6 @@ $ jekyll serve --detach
# => Same as `jekyll serve` but will detach from the current terminal.
# If you need to kill the server, you can `kill -9 1234` where "1234" is the PID.
# If you cannot find the PID, then do, `ps aux | grep jekyll` and kill the instance. [Read more](http://unixhelp.ed.ac.uk/shell/jobz5.html).

$ jekyll serve --watch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change this to jekyll serve --no-watch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way is fine. It depends on how verbose you think it needs to be.

FWIW, I usually just wrap the commands in a test.sh script and run it that way, so --watch is not a switch I flip frequently (Default behavior is enabled).

If you can think of a use case where a separate command makes sense, go for it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should show an example with --no-watch so it's obvious that it exists. We should also add a note to jekyll serve that says it automatically regenerates.

parkr added a commit that referenced this pull request Sep 27, 2014
@parkr parkr merged commit 7539e21 into jekyll:master Sep 27, 2014
parkr added a commit that referenced this pull request Sep 27, 2014
@chrisfinazzo chrisfinazzo deleted the remove-explicit-serve-from-docs branch September 27, 2014 18:51
@chrisfinazzo chrisfinazzo restored the remove-explicit-serve-from-docs branch September 28, 2014 03:49
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants