-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak page description #2982
Tweak page description #2982
Conversation
Remove unneeded end tag, and also strip newlines. Move `X-UA-Compatible` just after `meta charset`.
Good call, strip_newlines is a good addition. |
@@ -7,7 +7,7 @@ layout: null | |||
<title>{{ site.title | xml_escape }}</title> | |||
<description>{{ site.description | xml_escape }}</description> | |||
<link>{{ site.url }}{{ site.baseurl }}/</link> | |||
<atom:link href="{{ "/feed.xml" | prepend: site.baseurl | prepend: site.url }}" rel="self" type="application/rss+xml" /> | |||
<atom:link href="{{ "/feed.xml" | prepend: site.baseurl | prepend: site.url }}" rel="self" type="application/rss+xml"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unneeded space before the end tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, do you think it helps at all for readability? I find it more readable with the space than without, but it could be just me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it's the same, plus this is the only place with a space before the end tag.
Cool, looking good. |
This is an example paragraph
that is broken into a few
lines. New lines render as
spaces in HTML. This is rendered as I reproduced this on a brand new jekyll site by adding this as the first paragraph to the "welcome-to-jekyll.markdown" post. I think the solution is to either keep the newlines inside the description meta tag or replace it with a custom liquid filter like this one: def newlines_to_spaces input
input.to_s.gsub(/\r?\n/, ' '.freeze)
end |
I've opened a new issue since this PR has been closed for so long. |
strip_newlines
in description (without this, I ended up with newlines inside the quotes)X-UA-Compatible
right aftermeta charset