Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link atom feed from html head #2996

Merged
merged 2 commits into from
Oct 12, 2014
Merged

Conversation

hickford
Copy link
Contributor

This makes it possible for browsers to autodiscover the feed. Fixes #2995

This makes it possible for browsers to autodiscover the feed. Fixes jekyll#2995
@@ -8,4 +8,5 @@

<link rel="stylesheet" href="{{ "/css/main.css" | prepend: site.baseurl }}">
<link rel="canonical" href="{{ page.url | replace:'index.html','' | prepend: site.baseurl | prepend: site.url }}">
<link rel="alternate" type="application/atom+xml" title="{{ site.title }}" href="/feed.xml" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Would you please make the feed link more like the others:

{{ "/feed.xml" | prepend: site.baseurl | prepend: site.url }}

@parkr parkr added the fix label Oct 12, 2014
@parkr parkr merged commit 7cad48a into jekyll:master Oct 12, 2014
@parkr
Copy link
Member

parkr commented Oct 12, 2014

Thanks!

parkr added a commit that referenced this pull request Oct 12, 2014
@rud
Copy link
Contributor

rud commented Nov 30, 2014

Tiny nit-pick that may be completely irrelevant: the feed.xml file is in RSS 2.0 format, not Atom. Should the type maybe be set to type="application/rss+xml"? Or is this of absolutely no consequence?

@parkr
Copy link
Member

parkr commented Nov 30, 2014

It's certainly of consequence. If it does not conform to the Atom spec, then let's change this. Submit a PR?

@rud
Copy link
Contributor

rud commented Dec 1, 2014

Most certainly, coming up.

rud added a commit to rud/jekyll that referenced this pull request Dec 1, 2014
rud added a commit to rud/jekyll that referenced this pull request Dec 2, 2014
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atom feed not linked from html pages
4 participants