Link atom feed from html head #2996

Merged
merged 2 commits into from Oct 12, 2014

Conversation

Projects
None yet
4 participants
@hickford
Contributor

hickford commented Oct 12, 2014

This makes it possible for browsers to autodiscover the feed. Fixes #2995

Link atom feed from html head
This makes it possible for browsers to autodiscover the feed. Fixes #2995
lib/site_template/_includes/head.html
@@ -8,4 +8,5 @@
<link rel="stylesheet" href="{{ "/css/main.css" | prepend: site.baseurl }}">
<link rel="canonical" href="{{ page.url | replace:'index.html','' | prepend: site.baseurl | prepend: site.url }}">
+ <link rel="alternate" type="application/atom+xml" title="{{ site.title }}" href="/feed.xml" />

This comment has been minimized.

@parkr

parkr Oct 12, 2014

Member

Great! Would you please make the feed link more like the others:

{{ "/feed.xml" | prepend: site.baseurl | prepend: site.url }}
@parkr

parkr Oct 12, 2014

Member

Great! Would you please make the feed link more like the others:

{{ "/feed.xml" | prepend: site.baseurl | prepend: site.url }}

@parkr parkr added the fix label Oct 12, 2014

@parkr parkr merged commit 7cad48a into jekyll:master Oct 12, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 12, 2014

Member

Thanks!

Member

parkr commented Oct 12, 2014

Thanks!

parkr added a commit that referenced this pull request Oct 12, 2014

@rud

This comment has been minimized.

Show comment
Hide comment
@rud

rud Nov 30, 2014

Contributor

Tiny nit-pick that may be completely irrelevant: the feed.xml file is in RSS 2.0 format, not Atom. Should the type maybe be set to type="application/rss+xml"? Or is this of absolutely no consequence?

Contributor

rud commented Nov 30, 2014

Tiny nit-pick that may be completely irrelevant: the feed.xml file is in RSS 2.0 format, not Atom. Should the type maybe be set to type="application/rss+xml"? Or is this of absolutely no consequence?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 30, 2014

Member

It's certainly of consequence. If it does not conform to the Atom spec, then let's change this. Submit a PR?

Member

parkr commented Nov 30, 2014

It's certainly of consequence. If it does not conform to the Atom spec, then let's change this. Submit a PR?

@rud

This comment has been minimized.

Show comment
Hide comment
@rud

rud Dec 1, 2014

Contributor

Most certainly, coming up.

Contributor

rud commented Dec 1, 2014

Most certainly, coming up.

rud added a commit to rud/jekyll that referenced this pull request Dec 1, 2014

rud added a commit to rud/jekyll that referenced this pull request Dec 2, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.