-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows Path Sanitation #3077
Conversation
I can confirm it works fine here!
BTW, maybe |
Great!! So glad it works. :) I was thinking about how we could bundle wdm, but the gemspec is turned into yaml so there are no conditional gems. So either everyone has to install wdm or no one gets it for free. A shortcoming of rubygems |
No big deal I guess, I mean it works even though the bundle doesn't have wdm here. |
unless clean_path.start_with?(base_directory) | ||
clean_path = clean_path.sub(/^\A\w\:\//, '/') | ||
|
||
unless clean_path.start_with?(base_directory.sub(/^\A\w\:\//, '/')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mastahyeti @gregose Does this look OK to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change the regex? I'm not even sure what combining ^
and \A
would result in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why I did this... need more 👀 on my PR's. Want to join Jekyll core? 😉 I'll get a fix for this out tonight as 2.5.2. D'oh! Thanks for catching it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking care of it here: #3089
Addresses @mastahyeti's comment in #3077: #3077 (comment)
Fixes #3068, alternative to #3071.
Benchmarks
Before
After
@jekyll/windows, would you please test?