New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rake task site:publish to fix minor bugs. #3254

Merged
merged 1 commit into from Jan 4, 2015

Conversation

Projects
None yet
4 participants
@flyinprogrammer
Contributor

flyinprogrammer commented Jan 4, 2015

  • Automate creating gh-pages directory
  • Ensure gh-pages dir always has correct branch checked out
  • Purge gh-pages of files so that a sync of site truly occurs
  • Ensure dot files are synced
  • Be exact with our exclusions to eliminate guess work
Update rake task site:publish to fix minor bugs.
*  Automate creating gh-pages directory
*  Ensure gh-pages dir always has correct branch checked out
*  Purge gh-pages of files so that a sync of site truly occurs
*  Ensure dot files are synced
*  Be exact with our exclusions to eliminate guess work
@flyinprogrammer

This comment has been minimized.

Show comment
Hide comment
@flyinprogrammer

flyinprogrammer Jan 4, 2015

Contributor

This will ensure the latest .gitignore from 'site' is copied, and that README and _sass/.sass-cache/89a83dca448ff37810b0714f8b03e869032bdae6/normalize.scssc are removed from gh-pages.

We might consider adding '.jekyll-metadata' to .gitignore, not sure though. 😐

Contributor

flyinprogrammer commented Jan 4, 2015

This will ensure the latest .gitignore from 'site' is copied, and that README and _sass/.sass-cache/89a83dca448ff37810b0714f8b03e869032bdae6/normalize.scssc are removed from gh-pages.

We might consider adding '.jekyll-metadata' to .gitignore, not sure though. 😐

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 4, 2015

Member

Very thorough work. Thank you!

Member

parkr commented Jan 4, 2015

Very thorough work. Thank you!

parkr added a commit that referenced this pull request Jan 4, 2015

@parkr parkr merged commit ff3fa84 into jekyll:master Jan 4, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jan 4, 2015

@doktorbro

This comment has been minimized.

Show comment
Hide comment
@doktorbro

doktorbro Jan 4, 2015

Member

@flyinprogrammer Why didn’t you use Rake::FileList#exclude?

Member

doktorbro commented Jan 4, 2015

@flyinprogrammer Why didn’t you use Rake::FileList#exclude?

@flyinprogrammer

This comment has been minimized.

Show comment
Hide comment
@flyinprogrammer

flyinprogrammer Jan 5, 2015

Contributor

@penibelst - Well, haha, truth be told I didn't know Rake had a FileList helper. Since this was my first commit to this project I was focusing on keeping the code simple and consistent with patterns that were in place.

Personally I've always used Dir.glob, but I see no reason why FileList could not be used. I'd be more than happy to submit another pull request using FileList if you'd like.

Edit: I think that's much better actually. Sorry for my ignorance!

Contributor

flyinprogrammer commented Jan 5, 2015

@penibelst - Well, haha, truth be told I didn't know Rake had a FileList helper. Since this was my first commit to this project I was focusing on keeping the code simple and consistent with patterns that were in place.

Personally I've always used Dir.glob, but I see no reason why FileList could not be used. I'd be more than happy to submit another pull request using FileList if you'd like.

Edit: I think that's much better actually. Sorry for my ignorance!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.