Move all regenerate? checking to Regenerator #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cursory glance says 👍 . Will take a closer look tonight. Thank you!! |
| } | ||
| metadata.write unless full_rebuild? | ||
| regenerator.write unless full_rebuild? |
There was a problem hiding this comment.
This method is kind of ambiguous.
There was a problem hiding this comment.
Alright, fixed. It was metadata.write before, which made sense, but now it's renamed to regenerator.write_metadata.
|
LGTM. @envygeeks / @mattr- , wanna take a look? |
|
👍 |
parkr
added a commit
that referenced
this pull request
Jan 20, 2015
parkr
added a commit
that referenced
this pull request
Jan 20, 2015
|
Thanks!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all Post/Page/Document
regenerate?checking to Regenerator (renamed from Metadata). Also allows non-core objects to be rendered with out an error (fixes #3311)./cc @parkr @envygeeks @crearc