New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all regenerate? checking to Regenerator #3326

Merged
merged 3 commits into from Jan 20, 2015

Conversation

Projects
None yet
4 participants
@alfredxing
Member

alfredxing commented Jan 18, 2015

Moves all Post/Page/Document regenerate? checking to Regenerator (renamed from Metadata). Also allows non-core objects to be rendered with out an error (fixes #3311).

/cc @parkr @envygeeks @crearc

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 18, 2015

Member

Cursory glance says 👍 . Will take a closer look tonight. Thank you!!

Member

parkr commented Jan 18, 2015

Cursory glance says 👍 . Will take a closer look tonight. Thank you!!

@parkr parkr added the Enhancement label Jan 18, 2015

@parkr parkr added this to the 3.0 milestone Jan 18, 2015

Show outdated Hide outdated lib/jekyll/site.rb Outdated
Show outdated Hide outdated test/test_regenerator.rb Outdated
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 20, 2015

Member

LGTM. @envygeeks / @mattr- , wanna take a look?

Member

parkr commented Jan 20, 2015

LGTM. @envygeeks / @mattr- , wanna take a look?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jan 20, 2015

Contributor

👍

Contributor

envygeeks commented Jan 20, 2015

👍

@parkr parkr merged commit c2f0b9a into jekyll:master Jan 20, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jan 20, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 20, 2015

Member

Thanks!!

Member

parkr commented Jan 20, 2015

Thanks!!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.