New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document addition of variable parameters to an include. #3581

Merged
merged 4 commits into from Mar 24, 2015

Conversation

Projects
None yet
5 participants
@daviewales
Contributor

daviewales commented Mar 17, 2015

This fixes issue #3577.

daviewales added some commits Mar 17, 2015

Document variable parameters for include.
The documentation has been updated to demonstrate variable parameters for an include.

    {% include footer.html param="value" variable-param=page.variable %}
Document variable parameters for include.
The documentation has been updated to demonstrate variable parameters for an include.

    {% include footer.html param="value" variable-param=page.variable %}
@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Mar 17, 2015

Member

👍 Though we might want to use bold or italic instead of all caps?

Member

alfredxing commented Mar 17, 2015

👍 Though we might want to use bold or italic instead of all caps?

Show outdated Hide outdated site/_docs/templates.md
{% highlight ruby %}
{% raw %}{% include footer.html param="value" %}{% endraw %}
{% raw %}{% include footer.html param="value" variable-param=page.variable %}{% endraw %}

This comment has been minimized.

@troyswanson

troyswanson Mar 17, 2015

Member

It is totally possible that I'm wrong, but I think dashes are not allowed in Liquid variables...

@troyswanson

troyswanson Mar 17, 2015

Member

It is totally possible that I'm wrong, but I think dashes are not allowed in Liquid variables...

This comment has been minimized.

@daviewales

daviewales Mar 17, 2015

Contributor

Dashes seem to be working on my end.

@daviewales

daviewales Mar 17, 2015

Contributor

Dashes seem to be working on my end.

@daviewales

This comment has been minimized.

Show comment
Hide comment
@daviewales

daviewales Mar 17, 2015

Contributor

@alfredxing I've changed it from ALL CAPS to strong.

Contributor

daviewales commented Mar 17, 2015

@alfredxing I've changed it from ALL CAPS to strong.

Show outdated Hide outdated site/_docs/templates.md
@@ -286,10 +286,10 @@ root of your source directory. This will embed the contents of
</p>
</div>
You can also pass parameters to an include:
You can also pass parameters to an include. Note that the variable parameter is **not** surrounded with the usual Liquid curly brackets:

This comment has been minimized.

@parkr

parkr Mar 18, 2015

Member

I don't understand "variable parameter" in this case. What do you think about:

Omit the quotation marks if you would like to send a variable's value, and do not include the curly brackets.

@parkr

parkr Mar 18, 2015

Member

I don't understand "variable parameter" in this case. What do you think about:

Omit the quotation marks if you would like to send a variable's value, and do not include the curly brackets.

This comment has been minimized.

@daviewales

daviewales Mar 18, 2015

Contributor

That seems OK. I would probably say:

Omit the quotation marks if you would like to send a variable's value. Liquid curly brackets should not be used here.

@daviewales

daviewales Mar 18, 2015

Contributor

That seems OK. I would probably say:

Omit the quotation marks if you would like to send a variable's value. Liquid curly brackets should not be used here.

This comment has been minimized.

@daviewales

daviewales Mar 18, 2015

Contributor

I've changed it to say

Omit the quotation marks to send a variable's value. Liquid curly brackets should not be used here:

@daviewales

daviewales Mar 18, 2015

Contributor

I've changed it to say

Omit the quotation marks to send a variable's value. Liquid curly brackets should not be used here:

parkr added a commit that referenced this pull request Mar 24, 2015

@parkr parkr merged commit 3a85aa0 into jekyll:master Mar 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Mar 24, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.