Performance: Sort files only once #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
👍 What's the performance improvement you're seeing with this? |
| @@ -15,10 +15,18 @@ def initialize(site) | |||
| def read | |||
| @site.layouts = LayoutReader.new(site).read | |||
| read_directories | |||
| sort_files | |||
not crazy much.. about 500ms of ~5s (for initial build and for each regeneration cycle) on a site with about 6000 files. but I guess you have to start somewhere :-) |
|
|
|
Pending responses it'll merge! |
|
Updated: Renamed the method |
envygeeks
added a commit
that referenced
this pull request
May 18, 2015
Performance: Sort files only once
envygeeks
added a commit
that referenced
this pull request
May 18, 2015
|
Would you mind releasing a beta5 release to Rubygems? |
|
It'll happen sometime in the next few days because I have a few more changes I would like to get into beta5 (aside from our new JRuby support.) Like thread pooling and possibly even collection fixes. |
|
If you need though I can cut a new release of our master image for Docker. |
|
Why not just call those beta6, @envygeeks? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3705.
Turns out the reason that it was slow for me was not that it was sorting at all but that it was sorting the same list of files over and over again.
Solution: Sort only once at the end of
#read, not every time we load more files from a directory (those functions are called recursively via#read_directories). This also ensures backwards compatibility for the regular code path (unless you have a plugin that directly calls#retrieve_postsetc. or stuff like that).@envygeeks @parkr @alfredxing