Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think you made a typo there #3918

Merged
merged 1 commit into from Aug 17, 2015
Merged

I think you made a typo there #3918

merged 1 commit into from Aug 17, 2015

Conversation

@parkr
Copy link
Member

parkr commented Aug 17, 2015

LGTM.

parkr added a commit that referenced this pull request Aug 17, 2015
I think you made a typo there
@parkr parkr merged commit 1c767fe into jekyll:master Aug 17, 2015
@TWiStErRob
Copy link
Contributor

@parkr I think it's actually those articles that are wrong. I removed this colon: https://github.com/TWiStErRob/twisterrob.github.io/blob/master/_config_dev.yml#L22 and the generated CSS style is not expanded any more (from _config_dev.yml), but the compressed (the one defined in _config.yml), so without colon the setting is being ignored.

@parkr
Copy link
Member

parkr commented Aug 17, 2015

@TWiStErRob We strip out the leading :, so Chris is correct for the latest code. What version are you using?

@TWiStErRob
Copy link
Contributor

Ah the latest. I use GH-Pages gem, maybe 2.6.0... I wish I could use edge on GH.

@envygeeks
Copy link
Contributor

@TWiStErRob you can, just build it and push the HTML (_site) instead of letting Github build it.

@pathawks
Copy link
Member

I can confirm that the colon is not necessary on Pages Gem v39 (Jekyll 2.4.0)

@gangsthub gangsthub deleted the patch-2 branch September 1, 2015 07:36
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants