Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error on empty permalink #4361

Merged
merged 6 commits into from Jan 16, 2016
Merged

Raise error on empty permalink #4361

merged 6 commits into from Jan 16, 2016

Commits on Jan 15, 2016

  1. Empty permalink now shows an error

    @pheuko
    pheuko committed Jan 15, 2016
    Copy the full SHA
    f8a6315 View commit details
    Browse the repository at this point in the history

  2. Check if permalink key was given

    @pheuko
    pheuko committed Jan 15, 2016
    Copy the full SHA
    5681742 View commit details
    Browse the repository at this point in the history

  3. Ensure no errors when there is no permalink

    @pheuko
    pheuko committed Jan 15, 2016
    Copy the full SHA
    156e093 View commit details
    Browse the repository at this point in the history

  4. Convertible: consolidate empty check into Convertible#read

    @parkr
    parkr committed Jan 15, 2016
    Copy the full SHA
    948dcf2 View commit details
    Browse the repository at this point in the history

  5. Convertible: separate data validation out of #read

    @parkr
    parkr committed Jan 15, 2016
    Copy the full SHA
    89db3c6 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2016

  1. Restructure data validation so that permalink check raises an error.

    @parkr
    parkr committed Jan 16, 2016
    Copy the full SHA
    06fa14c View commit details
    Browse the repository at this point in the history