New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify method for copying special files from repo to site #4601
Conversation
Can we add a bit of splitting to that method please? Perhaps use Pathname or Pathutil? Anything that merges the logic of all that |
@envygeeks I'm afraid I don't follow. Can you elaborate? |
@benbalter Pathutil can encapsulate everything you did more more cleanly. file = Pathutil.new(file)
data = file.read
contents = "stuff"
file.sub_ext(".md").write(
contents
) As stated before you'll have to manually add |
@envygeeks started to implement things, and think a refactor like that is better suited for a subsequent pull request to keep this one targeted. The abstraction isn't as clean because we're actually working with two different files. |
@@ -1,3 +1,5 @@ | |||
# History | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to leave this out. I believe our changelog generator will nix it anyway.
Good call. Fixed. |
Thanks, Ben! @jekyllbot: merge +dev |
In support of #4596, this pull request introduces a
siteify
method to the rake tasks, to DRY up copying markdown files from the root to the site (CONDUCT, CONTRIBUTING, and HISTORY).