Update Rubocop rules #4886
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,80 +1,199 @@ | ||
| --- | ||
| AllCops: | ||
| TargetRubyVersion: 2.0 | ||
| Include: | ||
| - lib/**/*.rb | ||
| Exclude: | ||
| - lib/jekyll/cleaner.rb | ||
| - lib/jekyll/collection.rb | ||
| - lib/jekyll/command.rb | ||
| - lib/jekyll/commands/build.rb | ||
| - lib/jekyll/commands/clean.rb | ||
| - lib/jekyll/commands/doctor.rb | ||
| - lib/jekyll/commands/help.rb | ||
| - lib/jekyll/commands/new.rb | ||
| - lib/jekyll/commands/serve | ||
| - lib/jekyll/commands/serve/servlet.rb | ||
| - lib/jekyll/commands/serve.rb | ||
| - lib/jekyll/configuration.rb | ||
| - lib/jekyll/converter.rb | ||
| - lib/jekyll/converters/identity.rb | ||
| - lib/jekyll/converters/markdown | ||
| - lib/jekyll/converters/markdown/kramdown_parser.rb | ||
| - lib/jekyll/converters/markdown/rdiscount_parser.rb | ||
| - lib/jekyll/converters/markdown/redcarpet_parser.rb | ||
| - lib/jekyll/converters/markdown.rb | ||
| - lib/jekyll/converters/smartypants.rb | ||
| - lib/jekyll/convertible.rb | ||
| - lib/jekyll/deprecator.rb | ||
| - lib/jekyll/document.rb | ||
| - lib/jekyll/drops/collection_drop.rb | ||
| - lib/jekyll/drops/document_drop.rb | ||
| - lib/jekyll/drops/drop.rb | ||
| - lib/jekyll/drops/jekyll_drop.rb | ||
| - lib/jekyll/drops/site_drop.rb | ||
| - lib/jekyll/drops/unified_payload_drop.rb | ||
| - lib/jekyll/drops/url_drop.rb | ||
| - lib/jekyll/entry_filter.rb | ||
| - lib/jekyll/errors.rb | ||
| - lib/jekyll/excerpt.rb | ||
| - lib/jekyll/external.rb | ||
| - lib/jekyll/filters.rb | ||
| - lib/jekyll/frontmatter_defaults.rb | ||
| - lib/jekyll/generator.rb | ||
| - lib/jekyll/hooks.rb | ||
| - lib/jekyll/layout.rb | ||
| - lib/jekyll/liquid_extensions.rb | ||
| - lib/jekyll/liquid_renderer/file.rb | ||
| - lib/jekyll/liquid_renderer/table.rb | ||
| - lib/jekyll/liquid_renderer.rb | ||
| - lib/jekyll/log_adapter.rb | ||
| - lib/jekyll/page.rb | ||
| - lib/jekyll/plugin.rb | ||
| - lib/jekyll/plugin_manager.rb | ||
| - lib/jekyll/publisher.rb | ||
| - lib/jekyll/reader.rb | ||
| - lib/jekyll/readers/collection_reader.rb | ||
| - lib/jekyll/readers/data_reader.rb | ||
| - lib/jekyll/readers/layout_reader.rb | ||
| - lib/jekyll/readers/page_reader.rb | ||
| - lib/jekyll/readers/post_reader.rb | ||
| - lib/jekyll/readers/static_file_reader.rb | ||
| - lib/jekyll/regenerator.rb | ||
| - lib/jekyll/related_posts.rb | ||
| - lib/jekyll/renderer.rb | ||
| - lib/jekyll/site.rb | ||
| - lib/jekyll/static_file.rb | ||
| - lib/jekyll/stevenson.rb | ||
| - lib/jekyll/tags/highlight.rb | ||
| - lib/jekyll/tags/include.rb | ||
| - lib/jekyll/tags/link.rb | ||
| - lib/jekyll/tags/post_url.rb | ||
| - lib/jekyll/theme.rb | ||
| - lib/jekyll/url.rb | ||
| - lib/jekyll/utils/ansi.rb | ||
| - lib/jekyll/utils/platforms.rb | ||
| - lib/jekyll/utils.rb | ||
| - lib/jekyll/version.rb | ||
| - lib/jekyll.rb | ||
| - bin/**/* | ||
| - script/**/* | ||
| - vendor/**/* | ||
| Lint/AmbiguousRegexpLiteral: | ||
| Exclude: | ||
| - features/step_definitions.rb | ||
|
There was a problem hiding this comment. You are actually working around a literal Ruby warning, so this error will still surface on other linters (like Atom Linter, Sublime Text Linter and others.) According to Cucumber themselves it seems the preferred way to fix this with them is to just use |
||
| Lint/EndAlignment: | ||
| Severity: error | ||
| Lint/UnreachableCode: | ||
| Severity: error | ||
| Lint/UselessAccessModifier: | ||
| Enabled: false | ||
| Metrics/AbcSize: | ||
| Max: 20 | ||
| Metrics/ClassLength: | ||
| Max: 240 | ||
| Exclude: | ||
| - !ruby/regexp /features\/.*.rb$/ | ||
| Metrics/CyclomaticComplexity: | ||
| Max: 8 | ||
| Metrics/LineLength: | ||
| Max: 90 | ||
| Severity: warning | ||
| Exclude: | ||
| - !ruby/regexp /features\/.*.rb/ | ||
| Metrics/MethodLength: | ||
| Max: 20 | ||
| CountComments: false | ||
| Severity: error | ||
| Metrics/ModuleLength: | ||
| Max: 240 | ||
| Metrics/ParameterLists: | ||
| Max: 4 | ||
| Metrics/PerceivedComplexity: | ||
| Max: 8 | ||
| Style/Alias: | ||
| Enabled: false | ||
| Style/AlignArray: | ||
| Enabled: false | ||
| Style/AlignHash: | ||
| SupportedLastArgumentHashStyles: always_ignore | ||
| Style/AlignParameters: | ||
| EnforcedStyle: with_fixed_indentation | ||
| Enabled: false | ||
| Style/AndOr: | ||
| Severity: error | ||
| Style/Attr: | ||
| Enabled: false | ||
| Style/BracesAroundHashParameters: | ||
| Enabled: false | ||
| Style/ClassAndModuleChildren: | ||
| Enabled: false | ||
| Style/Documentation: | ||
| Enabled: false | ||
| Exclude: | ||
| - !ruby/regexp /features\/.*.rb$/ | ||
| Style/DoubleNegation: | ||
| Enabled: false | ||
| Style/EmptyLinesAroundAccessModifier: | ||
| Enabled: false | ||
| Style/EmptyLinesAroundModuleBody: | ||
| Enabled: false | ||
| Style/ExtraSpacing: | ||
| AllowForAlignment: true | ||
| Style/FileName: | ||
| Enabled: false | ||
| Style/FirstParameterIndentation: | ||
| EnforcedStyle: consistent | ||
| Style/GuardClause: | ||
| Enabled: false | ||
| Style/HashSyntax: | ||
| EnforcedStyle: hash_rockets | ||
| Severity: error | ||
| Style/IfUnlessModifier: | ||
| Enabled: false | ||
| Style/IndentArray: | ||
| EnforcedStyle: consistent | ||
| Style/IndentHash: | ||
| EnforcedStyle: consistent | ||
| Style/IndentationWidth: | ||
| Severity: error | ||
| Style/ModuleFunction: | ||
| Enabled: false | ||
| Style/MultilineMethodCallIndentation: | ||
| EnforcedStyle: indented | ||
| Style/MultilineOperationIndentation: | ||
| EnforcedStyle: indented | ||
| Style/MultilineTernaryOperator: | ||
| Severity: error | ||
| Style/PercentLiteralDelimiters: | ||
| PreferredDelimiters: | ||
| "%q": "{}" | ||
| "%Q": "{}" | ||
| "%r": "{}" | ||
| "%s": "()" | ||
| "%w": "()" | ||
| "%W": "()" | ||
| "%x": "()" | ||
| Style/RedundantReturn: | ||
| Enabled: false | ||
| Style/RedundantSelf: | ||
| Enabled: false | ||
| Style/RegexpLiteral: | ||
| EnforcedStyle: slashes | ||
| Style/RescueModifier: | ||
| Enabled: false | ||
| Style/SignalException: | ||
| EnforcedStyle: only_raise | ||
| Style/SingleLineMethods: | ||
| Enabled: false | ||
| Style/SpaceAroundOperators: | ||
| Enabled: false | ||
| Style/SpaceInsideBrackets: | ||
| Enabled: false | ||
| Style/StringLiterals: | ||
| Enabled: false | ||
|
There was a problem hiding this comment. I would love if we kicked this on, I like Github have a huge love of "" over '' because I find that I interpolate more than I don't but I'll digress that I don't even know if Github themselves enforces it in their own source. |
||
| EnforcedStyle: double_quotes | ||
| Style/StringLiteralsInInterpolation: | ||
| EnforcedStyle: double_quotes | ||
| Style/UnneededCapitalW: | ||
| Enabled: false | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this not only broadened our scope but possibly lessoned it no? This list would be mighty unmaintainable an seems refactor unfriendly. We shouldn't expect users to maintain our Rubocop file, my vote is for sticking with the old list at least on this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@envygeeks In terms of
AllCops.Exclude, I added each file individually so we can go through each and enable one-by-one. It's easier to review PR's for one or a handful of files and it means we can add the CodeClimate CI status now instead of waiting.