Rubocop: test/* #4947

Merged
merged 12 commits into from May 26, 2016

Conversation

Projects
None yet
4 participants
@pathawks
Member

pathawks commented May 25, 2016

+ "markdown" => "kramdown",
+ :permalink => "date",
+ "baseurl" => "/",
+ :include => [".htaccess"],

This comment has been minimized.

@envygeeks

envygeeks May 25, 2016

Contributor

This should be %w(.htaccess), did it not throw an error for that?

@envygeeks

envygeeks May 25, 2016

Contributor

This should be %w(.htaccess), did it not throw an error for that?

This comment has been minimized.

@pathawks

pathawks May 25, 2016

Member

No sir, it did not.

@pathawks

pathawks May 25, 2016

Member

No sir, it did not.

+ "markdown" => "kramdown",
+ "permalink" => "date",
+ "baseurl" => "/",
+ "include" => [".htaccess"],

This comment has been minimized.

@envygeeks

envygeeks May 25, 2016

Contributor

""

@envygeeks

envygeeks May 25, 2016

Contributor

""

test/test_configuration.rb
+ assert_equal(
+ Utils.deep_merge_hashes(
+ defaults,
+ { "baseurl" => "http://wahoo.dev" }

This comment has been minimized.

@envygeeks

envygeeks May 25, 2016

Contributor
Utils.deep_merge(arg1, {
  :key => :val
})
@envygeeks

envygeeks May 25, 2016

Contributor
Utils.deep_merge(arg1, {
  :key => :val
})
@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks May 25, 2016

Member

Rubocop Approves

Member

pathawks commented May 25, 2016

Rubocop Approves

test/test_configuration.rb
@@ -1,23 +1,25 @@
-require 'helper'
+# rubocop:disable Metrics/ClassLength

This comment has been minimized.

@pathawks

pathawks May 25, 2016

Member

I wonder if we should just disable Metrics/ClassLength for all of test/?

@pathawks

pathawks May 25, 2016

Member

I wonder if we should just disable Metrics/ClassLength for all of test/?

This comment has been minimized.

@envygeeks

envygeeks May 25, 2016

Contributor

The only way to do that would be to exclude all of tests from the metrics (I'm not against this, I wonder what @parkr thinks?) Other than that there is no way other than by file.

@envygeeks

envygeeks May 25, 2016

Contributor

The only way to do that would be to exclude all of tests from the metrics (I'm not against this, I wonder what @parkr thinks?) Other than that there is no way other than by file.

This comment has been minimized.

@pathawks

pathawks May 25, 2016

Member

I believe we can disable just this metric from .rubocop.yml

If you don’t mind, I’ll give it a shot

@pathawks

pathawks May 25, 2016

Member

I believe we can disable just this metric from .rubocop.yml

If you don’t mind, I’ll give it a shot

This comment has been minimized.

@envygeeks

envygeeks May 25, 2016

Contributor

Yeah, I say go for it.

@envygeeks

envygeeks May 25, 2016

Contributor

Yeah, I say go for it.

This comment has been minimized.

@parkr

parkr May 25, 2016

Member

@pathawks Yep, you can safely exclude all of test/ from Metrics/ClassLength. I still would like them tested for the other cops as they're arguably the worst part of our codebase 😆

@parkr

parkr May 25, 2016

Member

@pathawks Yep, you can safely exclude all of test/ from Metrics/ClassLength. I still would like them tested for the other cops as they're arguably the worst part of our codebase 😆

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks May 25, 2016

Contributor

:shipit:

Contributor

envygeeks commented May 25, 2016

:shipit:

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks May 26, 2016

Member

These merge conflicts are killing me 😭

Member

pathawks commented May 26, 2016

These merge conflicts are killing me 😭

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks May 26, 2016

Contributor

haha, yeah that'll happen when you send a million pull requests :P

Contributor

envygeeks commented May 26, 2016

haha, yeah that'll happen when you send a million pull requests :P

@@ -68,6 +57,7 @@ Metrics/ClassLength:
Max: 240
Exclude:
- !ruby/regexp /features\/.*.rb$/
+ - !ruby/regexp /test\/.*.rb$/

This comment has been minimized.

@pathawks

pathawks May 26, 2016

Member

Yep, you can safely exclude all of test/ from Metrics/ClassLength.

You got it, boss 👍

@pathawks

pathawks May 26, 2016

Member

Yep, you can safely exclude all of test/ from Metrics/ClassLength.

You got it, boss 👍

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 26, 2016

Member

@pathawks ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️

@jekyllbot: merge +dev

Member

parkr commented May 26, 2016

@pathawks ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit cd63272 into jekyll:master May 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request May 26, 2016

@pathawks pathawks deleted the pathawks:rubocop/tests branch May 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment