Rubocop: test/* #4947
Rubocop: test/* #4947
Conversation
| "markdown" => "kramdown", | ||
| :permalink => "date", | ||
| "baseurl" => "/", | ||
| :include => [".htaccess"], |
There was a problem hiding this comment.
This should be %w(.htaccess), did it not throw an error for that?
|
✅ Rubocop Approves |
| @@ -1,23 +1,25 @@ | |||
| require 'helper' | |||
| # rubocop:disable Metrics/ClassLength | |||
There was a problem hiding this comment.
I wonder if we should just disable Metrics/ClassLength for all of test/?
There was a problem hiding this comment.
The only way to do that would be to exclude all of tests from the metrics (I'm not against this, I wonder what @parkr thinks?) Other than that there is no way other than by file.
There was a problem hiding this comment.
I believe we can disable just this metric from .rubocop.yml
If you don’t mind, I’ll give it a shot
There was a problem hiding this comment.
@pathawks Yep, you can safely exclude all of test/ from Metrics/ClassLength. I still would like them tested for the other cops as they're arguably the worst part of our codebase 😆
|
|
|
These merge conflicts are killing me 😭 |
|
haha, yeah that'll happen when you send a million pull requests :P |
| @@ -68,6 +57,7 @@ Metrics/ClassLength: | |||
| Max: 240 | |||
| Exclude: | |||
| - !ruby/regexp /features\/.*.rb$/ | |||
| - !ruby/regexp /test\/.*.rb$/ | |||
There was a problem hiding this comment.
Yep, you can safely exclude all of
test/fromMetrics/ClassLength.
You got it, boss 👍
|
@pathawks ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ @jekyllbot: merge +dev |
#4885