Prevent reset of page in Liquid payload right before rendering layouts #5009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are apparently failing... |
|
Checks are fine, restarted the test for you. I'm curious if this will have any problems down the line but it's LGTM. |
parkr
changed the title
|
I'm not familiar with this .feature syntax, this reads like plain English. The test will execute this as-is?? |
|
Added a scenario. I would love some code review as this is a first for me. |
|
Looks good to me! Failing Travis check is a formatting error unrelated to your change. Thank you 😄 @jekyllbot: merge +bug |
Yes it does! 😄 https://travis-ci.org/jekyll/jekyll/jobs/137730352#L466 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this prevents the workaround from working anymore.