New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent reset of page in Liquid payload right before rendering layouts #5009

Merged
merged 2 commits into from Jun 15, 2016

Conversation

Projects
None yet
4 participants
@nasht00
Contributor

nasht00 commented Jun 14, 2016

Note that this prevents the workaround from working anymore.

@nasht00

This comment has been minimized.

Show comment
Hide comment
@nasht00

nasht00 Jun 14, 2016

Contributor

Checks are apparently failing...

Contributor

nasht00 commented Jun 14, 2016

Checks are apparently failing...

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jun 14, 2016

Contributor

Checks are fine, restarted the test for you. I'm curious if this will have any problems down the line but it's LGTM. :shipit:

Contributor

envygeeks commented Jun 14, 2016

Checks are fine, restarted the test for you. I'm curious if this will have any problems down the line but it's LGTM. :shipit:

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 14, 2016

Member

Perfect! @nasht00, would you please add a test for this? Create a hook like you did in #4414 and place it in a .feature file. You may create a new scenario in features/hooks.feature if you like. 😄 I don't want to break this again!

Fixes #4414.

Member

parkr commented Jun 14, 2016

Perfect! @nasht00, would you please add a test for this? Create a hook like you did in #4414 and place it in a .feature file. You may create a new scenario in features/hooks.feature if you like. 😄 I don't want to break this again!

Fixes #4414.

@parkr parkr added the needs-work label Jun 14, 2016

@parkr parkr changed the title from Prevent reset of page to fix #4414 to Prevent reset of page in Liquid payload right before rendering layouts Jun 14, 2016

@nasht00

This comment has been minimized.

Show comment
Hide comment
@nasht00

nasht00 Jun 15, 2016

Contributor

I'm not familiar with this .feature syntax, this reads like plain English. The test will execute this as-is??

Contributor

nasht00 commented Jun 15, 2016

I'm not familiar with this .feature syntax, this reads like plain English. The test will execute this as-is??

@jekyllbot jekyllbot removed the needs-work label Jun 15, 2016

@nasht00

This comment has been minimized.

Show comment
Hide comment
@nasht00

nasht00 Jun 15, 2016

Contributor

Added a scenario. I would love some code review as this is a first for me.

Contributor

nasht00 commented Jun 15, 2016

Added a scenario. I would love some code review as this is a first for me.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 15, 2016

Member

Looks good to me! Failing Travis check is a formatting error unrelated to your change. Thank you 😄

@jekyllbot: merge +bug

Member

parkr commented Jun 15, 2016

Looks good to me! Failing Travis check is a formatting error unrelated to your change. Thank you 😄

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 713fbb6 into jekyll:master Jun 15, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jekyllbot jekyllbot added bug fix labels Jun 15, 2016

jekyllbot added a commit that referenced this pull request Jun 15, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 15, 2016

Member

I'm not familiar with this .feature syntax, this reads like plain English. The test will execute this as-is??

Yes it does! 😄 https://travis-ci.org/jekyll/jekyll/jobs/137730352#L466

Member

parkr commented Jun 15, 2016

I'm not familiar with this .feature syntax, this reads like plain English. The test will execute this as-is??

Yes it does! 😄 https://travis-ci.org/jekyll/jekyll/jobs/137730352#L466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment