rubocop: lib/jekyll/collection.rb #5022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parkr any thoughts about this PR? 😄 |
| else | ||
| Jekyll.logger.debug "Skipped From Publishing:", doc.relative_path | ||
| end | ||
| read_docs(full_path) |
There was a problem hiding this comment.
In this case, you're just reading one document. Thus, this should be singular: read_document(full_path).
|
Two naming nits. Otherwise, LGTM. |
|
@jekyll/core, could one of you take a look at this and give it a LGTM? |
|
|
||
| private | ||
| def read_docs(full_path) | ||
| doc = Jekyll::Document.new(full_path, { :site => site, :collection => self }) |
There was a problem hiding this comment.
doc = Document.new(full_path, {
:site => site, :collection => self
})
doc.read
if site.publisher.publish?(doc) || !write?There was a problem hiding this comment.
You don't like the 1-line solution there? I think it reads nicely. We could even remove the curly braces:
doc = Document.new(full_path, :site => site, :collection => self)There was a problem hiding this comment.
I do like the version you've given @parkr.
|
Just a few comments! Thanks. |
|
LGTM. @envygeeks? |
|
LGTM. |
|
@jekyllbot: merge +dev |
jekyllbot
added a commit
that referenced
this pull request
Jul 16, 2016
stevecheckoway
pushed a commit
to stevecheckoway/jekyll
that referenced
this pull request
Jul 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4885