Add cucumber feature to test for bonafide theme gems #5384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
force-pushed
the
theme-gem-feature
branch
from
34968c8
to
e71e09f
Compare
|
I'd like to drop the entire commit related to theme-gem fixture now that this test runs against the theme dir scaffolding generated by |
ashmaroli
force-pushed
the
theme-gem-feature
branch
from
e71e09f
to
1d6e7b0
Compare
|
squashed and rebased.. |
|
(Will review once Travis is passing.) |
this cucumber feature follows the likely steps a theme designer would take to build a Rubygem of his theme starting from the scaffolding generated by `jekyll new-theme` command and further checks if the gem built actually has the files he planned to include.
ashmaroli
force-pushed
the
theme-gem-feature
branch
from
8b558d1
to
1fb4dce
Compare
|
updated against HEAD and got travis to pass 🎉 |
parkr
reviewed
Sep 29, 2016
| When I decide to build the theme gem | ||
| Then I should get a zero exit status | ||
| When I run git add . | ||
| Then I should get a zero exit status |
There was a problem hiding this comment.
These check the exit status of the Jekyll build, I think. They'll have to be updated to see what the latest command was and read its build status.
|
Sure! Thanks! @jekyllbot: merge +dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a cucumber feature to follow the steps a user would take to build a theme gem and check if it is ready for distribution using theme generated by
jekyll new-themeRef: #5362
/cc @parkr