New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cucumber feature to test for bonafide theme gems #5384

Merged
merged 4 commits into from Nov 29, 2016

Conversation

Projects
None yet
3 participants
@ashmaroli
Member

ashmaroli commented Sep 20, 2016

Adds a cucumber feature to follow the steps a user would take to build a theme gem and check if it is ready for distribution using theme generated by jekyll new-theme

Ref: #5362

/cc @parkr

@parkr parkr added the tests label Sep 20, 2016

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 21, 2016

Member

I'd like to drop the entire commit related to theme-gem fixture now that this test runs against the theme dir scaffolding generated by jekyll new-theme

Member

ashmaroli commented Sep 21, 2016

I'd like to drop the entire commit related to theme-gem fixture now that this test runs against the theme dir scaffolding generated by jekyll new-theme

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 23, 2016

Member

squashed and rebased..

Member

ashmaroli commented Sep 23, 2016

squashed and rebased..

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 28, 2016

Member

(Will review once Travis is passing.)

Member

parkr commented Sep 28, 2016

(Will review once Travis is passing.)

ashmaroli added some commits Sep 19, 2016

add theme-gem feature for bonafide theme gems
this cucumber feature follows the likely steps a theme designer would take
to build a Rubygem of his theme starting from the scaffolding generated by
`jekyll new-theme` command and further checks if the gem built actually
has the files he planned to include.
@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 29, 2016

Member

updated against HEAD and got travis to pass 🎉

Member

ashmaroli commented Sep 29, 2016

updated against HEAD and got travis to pass 🎉

Show outdated Hide outdated features/theme_gem.feature
When I decide to build the theme gem
Then I should get a zero exit status
When I run git add .
Then I should get a zero exit status

This comment has been minimized.

@parkr

parkr Sep 29, 2016

Member

These check the exit status of the Jekyll build, I think. They'll have to be updated to see what the latest command was and read its build status.

@parkr

parkr Sep 29, 2016

Member

These check the exit status of the Jekyll build, I think. They'll have to be updated to see what the latest command was and read its build status.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 29, 2016

Member

Sure! Thanks!

@jekyllbot: merge +dev

Member

parkr commented Nov 29, 2016

Sure! Thanks!

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit a236790 into jekyll:master Nov 29, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Nov 29, 2016

@ashmaroli ashmaroli deleted the ashmaroli:theme-gem-feature branch Nov 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment