Exclude period from sanitization

[levlaz]

Excluding period from sanitize_filename allows users to have periods in
the name of a data file.

fix #5429

[levlaz]

Does anyone know what this failure means?

Failure:

TestSite#test_: configuring sites should have an array for plugins by default.  [/home/travis/build/jekyll/jekyll/test/test_site.rb:7]

Minitest::Assertion: --- expected

+++ actual

@@ -1 +1 @@

-["/home/travis/build/jekyll/jekyll/_plugins"]

+["/home/travis/build/jekyll/jekyll/test/source/_plugins"]

I am not getting this locally (OS X, Ruby 2.3.1), does not look like it has anything to do with these changes either.

[ashmaroli]

@levlaz, that error is a known bug actually. The error occurs in random test-suites for random rvm versions.. it'll go away when our maintainers will restart that test for you..

[pathawks]

it'll go away when our maintainers will restart that test for you.

✅

[ashmaroli]

@levlaz there's a similar fix in an older PR #5433

[parkr]

Thanks! We appreciate the pull request. Unfortunately, we won't be able to accept this patch.

We sanitize the period out on purpose: the . is what Liquid uses to traverse hashes. Consider:

{{ site.data.my_file.some_key_in_that_file }}

Each is delineated by a .. Liquid would error if we allowed periods in filenames, because it wouldn't know what is what:

{{ site.data.my.file.some_key_in_that_file }}

This would translate to:

{{ site[data][my][file][some_key_in_that_file] }}

#5433 correctly strips the period from directory names as is required for proper data access.