`jekyll new-theme` should specify Jekyll as a runtime dependency for the theme #5457

Merged
merged 1 commit into from Oct 24, 2016

Projects

None yet

4 participants

@ashmaroli
Contributor

Themes created with Jekyll 3.3.x will run with only Jekyll 3.3.x

/cc @jekyll/ecosystem

@ashmaroli ashmaroli replace development_dependency with runtime_dependency
08b3005
@parkr
Member
parkr commented Oct 6, 2016

Last time I tried this Bundler gave me a "Circular dependency" error, but let me know if you don't get the same. 😄

@ashmaroli
Contributor

Last time I tried this Bundler gave me a "Circular dependency" error,

For this to happen, Jekyll has to depend on a theme too.. but since it doesnt, I dont think bundler will care..

@parkr
parkr approved these changes Oct 24, 2016 View changes
@parkr parkr changed the title from replace development_dependency with runtime_dependency to `jekyll new-theme` should specify Jekyll as a runtime dependency for the theme Oct 24, 2016
@parkr
Member
parkr commented Oct 24, 2016

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 4896f54 into jekyll:master Oct 24, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jekyllbot jekyllbot added bug fix labels Oct 24, 2016
@ashmaroli ashmaroli deleted the ashmaroli:dependency-template branch Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment