jekyll new-theme should specify Jekyll as a runtime dependency for the theme
#5457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Last time I tried this Bundler gave me a "Circular dependency" error, but let me know if you don't get the same. 😄 |
For this to happen, Jekyll has to depend on a theme too.. but since it doesnt, I dont think bundler will care.. |
parkr
approved these changes
Oct 24, 2016
parkr
changed the title
jekyll new-theme should specify Jekyll as a runtime dependency for the theme
|
@jekyllbot: merge +bug |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Themes created with Jekyll 3.3.x will run with only Jekyll 3.3.x
/cc @jekyll/ecosystem