Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of a sample "typical post" #5473

Merged
merged 3 commits into from
Jan 9, 2017
Merged

Conversation

kentonh
Copy link
Contributor

@kentonh kentonh commented Oct 10, 2016

So, I thought this section in the docs would be a good place to put the anatomy of a post .md file.

@DirtyF
Copy link
Member

DirtyF commented Oct 10, 2016

/cc @jekyll/documentation

Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIAC I stay neutral to add a post example in the documentation, even if Jekyll already comes with a default post.

date: 2015-11-17 16:16:01 -0600
categories: jekyll update
---
You’ll find this post in your `_posts` directory. Go ahead and edit it and re-build the site to see your changes. You can rebuild the site in many different ways, but the most common way is to run `jekyll serve`, which launches a web server and auto-regenerates your site when a file is updated.
Copy link
Member

@DirtyF DirtyF Oct 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change command to bundle exec jekyll serve to be coherent with the rest of the documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, but this is pulled directly from the sample post in the current _posts directory in the repo.

Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor capitalization errors (e.g. 'Title' should be 'title') but in general I think this is a good thing. Folks reading the documentation about posts might find an example very helpful.

@DirtyF
Copy link
Member

DirtyF commented Nov 9, 2016

Hi @kentonh, could you 🙏 rebase this before merge? Docs have moved to docs folder. Thanks!

@DirtyF DirtyF mentioned this pull request Jan 8, 2017
kentonh and others added 3 commits January 9, 2017 15:19
So, I thought this section in the docs would be a good place to put the anatomy of a post .md file.
Updated to be consistent with the rest of documentation.
@DirtyF
Copy link
Member

DirtyF commented Jan 9, 2017

@jekyllbot: merge +docs

closes #5735

@DirtyF DirtyF closed this Jan 9, 2017
@jekyllbot jekyllbot merged commit 1c4833c into jekyll:master Jan 9, 2017
jekyllbot added a commit that referenced this pull request Jan 9, 2017
@zlatanvasovic
Copy link
Contributor

Ugh what was up with those 250 commits? 😕

@DirtyF
Copy link
Member

DirtyF commented Jan 9, 2017

@zdroid refresh 😅

@zlatanvasovic
Copy link
Contributor

@DirtyF Yeah, I noticed. Imagine merging 250 commits. 😆

@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants