Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse gsub #5494

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Collapse gsub #5494

merged 1 commit into from
Oct 19, 2016

Conversation

pathawks
Copy link
Member

I found a couple places where I could combine two gsubs into one 馃憤

@pathawks
Copy link
Member Author

/cc: @jekyll/performance

parkr
parkr approved these changes Oct 19, 2016
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀 馃懐

Feel free to merge with jekyllbot, @pathawks! I'd personally use +minor for this but up to you 馃憤

@pathawks
Copy link
Member Author

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 0d8e21f into master Oct 19, 2016
@jekyllbot jekyllbot deleted the pr/gsub branch October 19, 2016 01:38
jekyllbot added a commit that referenced this pull request Oct 19, 2016
@jekyllbot
Update history to reflect merge of #5494 [ci skip]
0f5c34d
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@envygeeks envygeeks envygeeks approved these changes

@parkr parkr parkr approved these changes

Assignees

@parkr parkr

Labels
frozen-due-to-age internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pathawks @envygeeks @parkr @jekyllbot