-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
no more invalid US-ASCII on lines 30 and 97 #5520
Conversation
Avoiding errors on `jekyll serve` ``` # jekyll serve -H 0.0.0.0 Configuration file: /jekyll-offline-docs/site/_config.yml Configuration file: /jekyll-offline-docs/site/_config.yml Source: /jekyll-offline-docs/site Destination: /jekyll-offline-docs/site/_site Incremental build: disabled. Enable with --incremental Generating... Conversion error: Jekyll::Converters::Scss encountered an error while converting 'css/screen.scss': Invalid US-ASCII character "\xE2" on line 30 jekyll 3.3.0 | Error: Invalid US-ASCII character "\xE2" on line 30 ``` And line 97 when 30 is adjusted...
/cc @jekyll/documentation |
@clorichel I haven't been able to reproduce this behavior on my configuration. Could you provide some context? |
@DirtyF Maybe he set a different charset, yet the PR is legit. It's wrong to use |
@DirtyF sure!
Get in your terminal: git clone https://github.com/jekyll/jekyll.git
cd jekyll
docker run -it -p 4000:4000 --rm -w /jekyll -v $(pwd):/jekyll ruby:2.3 /bin/bash This will connect you to the Then, within your Docker container: gem install jekyll
bundle install
cd site
jekyll serve -H 0.0.0.0 # there you got the error
exit # automatically remove the container thanks to `--rm` |
@clorichel thanks, looks like that's something @jekyll/core should be aware of. |
@jekyllbot: merge +minor |
Oh, hey @clorichel there is a conflict do you mind resolving it so we can merge? Thanks! |
This is now |
Avoiding errors on
jekyll serve
And line 97 when 30 is adjusted...
Will be super usefull to have the doc offline while travelling, thank you for that guys 馃憤