New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

no more invalid US-ASCII on lines 30 and 97 #5520

Merged
merged 1 commit into from Nov 10, 2016

Conversation

Projects
None yet
7 participants
@clorichel
Contributor

clorichel commented Oct 30, 2016

Avoiding errors on jekyll serve

# jekyll serve -H 0.0.0.0
Configuration file: /jekyll-offline-docs/site/_config.yml
Configuration file: /jekyll-offline-docs/site/_config.yml
            Source: /jekyll-offline-docs/site
       Destination: /jekyll-offline-docs/site/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
  Conversion error: Jekyll::Converters::Scss encountered an error while converting 'css/screen.scss':
                    Invalid US-ASCII character "\xE2" on line 30
jekyll 3.3.0 | Error:  Invalid US-ASCII character "\xE2" on line 30

And line 97 when 30 is adjusted...


Will be super usefull to have the doc offline while travelling, thank you for that guys 馃憤

no more invalid US-ASCII on lines 30 and 97
Avoiding errors on `jekyll serve`

```
# jekyll serve -H 0.0.0.0
Configuration file: /jekyll-offline-docs/site/_config.yml
Configuration file: /jekyll-offline-docs/site/_config.yml
            Source: /jekyll-offline-docs/site
       Destination: /jekyll-offline-docs/site/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
  Conversion error: Jekyll::Converters::Scss encountered an error while converting 'css/screen.scss':
                    Invalid US-ASCII character "\xE2" on line 30
jekyll 3.3.0 | Error:  Invalid US-ASCII character "\xE2" on line 30
```

And line 97 when 30 is adjusted...
@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 30, 2016

Member

@clorichel I haven't been able to reproduce this behavior on my configuration. Could you provide some context?

Member

DirtyF commented Oct 30, 2016

@clorichel I haven't been able to reproduce this behavior on my configuration. Could you provide some context?

@zdroid

This comment has been minimized.

Show comment
Hide comment
@zdroid

zdroid Oct 30, 2016

Member

@DirtyF Maybe he set a different charset, yet the PR is legit. It's wrong to use ` for apostrophes.

Member

zdroid commented Oct 30, 2016

@DirtyF Maybe he set a different charset, yet the PR is legit. It's wrong to use ` for apostrophes.

@clorichel

This comment has been minimized.

Show comment
Hide comment
@clorichel

clorichel Oct 30, 2016

Contributor

@DirtyF sure!

  • macOS Sierra 10.12.1
  • with Docker Version 1.12.1 (build: 12133)

Get in your terminal:

git clone https://github.com/jekyll/jekyll.git
cd jekyll
docker run -it -p 4000:4000 --rm -w /jekyll -v $(pwd):/jekyll ruby:2.3 /bin/bash

This will connect you to the /bin/bash of a throwable ruby:2.3 Docker container, mapping current directory $(pwd) to /jekyll in the container, setting /jekyll as the working directory in the container (so you don't have to cd /jekyll inside your container), automatically removing the container when it exits (--rm).

Then, within your Docker container:

gem install jekyll
bundle install
cd site
jekyll serve -H 0.0.0.0 # there you got the error
exit # automatically remove the container thanks to `--rm`
Contributor

clorichel commented Oct 30, 2016

@DirtyF sure!

  • macOS Sierra 10.12.1
  • with Docker Version 1.12.1 (build: 12133)

Get in your terminal:

git clone https://github.com/jekyll/jekyll.git
cd jekyll
docker run -it -p 4000:4000 --rm -w /jekyll -v $(pwd):/jekyll ruby:2.3 /bin/bash

This will connect you to the /bin/bash of a throwable ruby:2.3 Docker container, mapping current directory $(pwd) to /jekyll in the container, setting /jekyll as the working directory in the container (so you don't have to cd /jekyll inside your container), automatically removing the container when it exits (--rm).

Then, within your Docker container:

gem install jekyll
bundle install
cd site
jekyll serve -H 0.0.0.0 # there you got the error
exit # automatically remove the container thanks to `--rm`
@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 30, 2016

Member

@clorichel thanks, looks like that's something @jekyll/core should be aware of.

Member

DirtyF commented Oct 30, 2016

@clorichel thanks, looks like that's something @jekyll/core should be aware of.

@parkr

parkr approved these changes Oct 30, 2016

@DirtyF

DirtyF approved these changes Nov 9, 2016

@DirtyF DirtyF removed the not-reproduced label Nov 9, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Nov 9, 2016

Contributor

@jekyllbot: merge +minor

Contributor

envygeeks commented Nov 9, 2016

@jekyllbot: merge +minor

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Nov 9, 2016

Contributor

Oh, hey @clorichel there is a conflict do you mind resolving it so we can merge? Thanks!

Contributor

envygeeks commented Nov 9, 2016

Oh, hey @clorichel there is a conflict do you mind resolving it so we can merge? Thanks!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 9, 2016

Member

This is now docs/_sass/_gridism.scss. 馃槃

Member

parkr commented Nov 9, 2016

This is now docs/_sass/_gridism.scss. 馃槃

@parkr parkr merged commit a856a94 into jekyll:master Nov 10, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Nov 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment