New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connector param to array_to_sentence_string filter #5597

Merged
merged 1 commit into from Nov 23, 2016

Conversation

Projects
None yet
5 participants
@thetimbanks
Contributor

thetimbanks commented Nov 22, 2016

When building a sentence based off an array, the default connector is "and". This will allow other terms to be used such as "or".

@pathawks

Seems reasonable. We just need to document this change.

@thetimbanks

This comment has been minimized.

Show comment
Hide comment
@thetimbanks

thetimbanks Nov 22, 2016

Contributor

Is that something I need to add to one of the markdown documents?

Contributor

thetimbanks commented Nov 22, 2016

Is that something I need to add to one of the markdown documents?

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Nov 22, 2016

Member

@thetimbanks Yup. The documentation for our filters is in /docs/_docs/templates.md. You will need to update the section describing array_to_sentence_string to explain the new parameter. 👍

Member

pathawks commented Nov 22, 2016

@thetimbanks Yup. The documentation for our filters is in /docs/_docs/templates.md. You will need to update the section describing array_to_sentence_string to explain the new parameter. 👍

@thetimbanks

This comment has been minimized.

Show comment
Hide comment
@thetimbanks

thetimbanks Nov 22, 2016

Contributor

I amended the documentation change in to the commit.

Contributor

thetimbanks commented Nov 22, 2016

I amended the documentation change in to the commit.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks
Member

pathawks commented Nov 23, 2016

@DirtyF

DirtyF approved these changes Nov 23, 2016

@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter Nov 23, 2016

Contributor

@jekyllbot: merge +minor

Contributor

benbalter commented Nov 23, 2016

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 7044549 into jekyll:master Nov 23, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter Nov 23, 2016

Contributor

Thanks @thetimbanks! 🦃 🌮 🎉

Contributor

benbalter commented Nov 23, 2016

Thanks @thetimbanks! 🦃 🌮 🎉

jekyllbot added a commit that referenced this pull request Nov 23, 2016

@thetimbanks

This comment has been minimized.

Show comment
Hide comment
@thetimbanks

thetimbanks Nov 23, 2016

Contributor

🦃 👍 Thanks!

Contributor

thetimbanks commented Nov 23, 2016

🦃 👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment