Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connector param to array_to_sentence_string filter #5597

Merged
merged 1 commit into from
Nov 23, 2016

Conversation

thetimbanks
Copy link
Contributor

When building a sentence based off an array, the default connector is "and". This will allow other terms to be used such as "or".

Copy link
Member

@pathawks pathawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. We just need to document this change.

@thetimbanks
Copy link
Contributor Author

Is that something I need to add to one of the markdown documents?

@pathawks
Copy link
Member

@thetimbanks Yup. The documentation for our filters is in /docs/_docs/templates.md. You will need to update the section describing array_to_sentence_string to explain the new parameter. 👍

@thetimbanks
Copy link
Contributor Author

I amended the documentation change in to the commit.

@pathawks
Copy link
Member

/cc @jekyll/ecosystem?

@benbalter
Copy link
Contributor

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 7044549 into jekyll:master Nov 23, 2016
@benbalter
Copy link
Contributor

Thanks @thetimbanks! 🦃 🌮 🎉

jekyllbot added a commit that referenced this pull request Nov 23, 2016
@thetimbanks
Copy link
Contributor Author

🦃 👍 Thanks!

@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants