New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix date parsing in file names to be stricter #5609

Merged
merged 4 commits into from Nov 29, 2016

Conversation

Projects
None yet
5 participants
@oe
Member

oe commented Nov 29, 2016

this fixes #5603

jona
@@ -492,4 +492,33 @@ def assert_equal_value(key, one, other)
assert_equal true, File.file?(@dest_file)
end
end
context "a document in a collection with dash-separated numeric file name" do

This comment has been minimized.

@oe

oe Nov 29, 2016

Member

we don't really need these tests because most others in this spec file will fail if the regex is wrong, but i added them for consistency

@oe

oe Nov 29, 2016

Member

we don't really need these tests because most others in this spec file will fail if the regex is wrong, but i added them for consistency

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 29, 2016

Member

Before this pull, the expected @site.posts.size was 51 in test/test_generated_site.rb
With this pull, a new file was added to /methods collection ( albeit ignored by Jekyll ) yet @site.posts.size fell to a 49 ..
which other files got ignored??

Member

ashmaroli commented Nov 29, 2016

Before this pull, the expected @site.posts.size was 51 in test/test_generated_site.rb
With this pull, a new file was added to /methods collection ( albeit ignored by Jekyll ) yet @site.posts.size fell to a 49 ..
which other files got ignored??

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Nov 29, 2016

Member

@ashmaroli okay, that is weird. i'll have a look

Member

oe commented Nov 29, 2016

@ashmaroli okay, that is weird. i'll have a look

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 29, 2016

Member

@fene these two files got ignored with this pull:

category/_posts/2008-9-23-categories.markdown
z_category/_posts/2008-9-23-categories.markdown

They were ignored because they have 9 instead of 09..

This could potentially break some existing sites.. so a documentation-update or a deprecation-release is warranted..

Member

ashmaroli commented Nov 29, 2016

@fene these two files got ignored with this pull:

category/_posts/2008-9-23-categories.markdown
z_category/_posts/2008-9-23-categories.markdown

They were ignored because they have 9 instead of 09..

This could potentially break some existing sites.. so a documentation-update or a deprecation-release is warranted..

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Nov 29, 2016

Member

ping @jekyll/core @jekyll/documentation what do you think about this?

Member

oe commented Nov 29, 2016

ping @jekyll/core @jekyll/documentation what do you think about this?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 29, 2016

Member

I guess we're covered documentation-wise.

posts

and that section has been around for years now

Member

ashmaroli commented Nov 29, 2016

I guess we're covered documentation-wise.

posts

and that section has been around for years now

jona added some commits Nov 29, 2016

jona
--global
--global
@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Nov 29, 2016

Member

^ weird travis error on the latest build

Member

oe commented Nov 29, 2016

^ weird travis error on the latest build

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 29, 2016

Member

Don't worry about it.. its a bug.. occurs randomly..
it'll go away when one of the maintainers will restart that lone test for you..

Member

ashmaroli commented Nov 29, 2016

Don't worry about it.. its a bug.. occurs randomly..
it'll go away when one of the maintainers will restart that lone test for you..

@DirtyF

DirtyF approved these changes Nov 29, 2016

@parkr

parkr approved these changes Nov 29, 2016

Nicely done, @fene!

@parkr parkr changed the title from fix date parsing in file names to fix date parsing in file names to be stricter Nov 29, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 29, 2016

Member

@jekyllbot: merge +bug

Member

parkr commented Nov 29, 2016

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit c8c6c6c into jekyll:master Nov 29, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels Nov 29, 2016

jekyllbot added a commit that referenced this pull request Nov 29, 2016

parkr added a commit that referenced this pull request Dec 16, 2016

parkr added a commit that referenced this pull request Mar 2, 2017

Failing test: abbreviated post dates are no longer read.
This is a regression introduced by #5609.

@parkr parkr referenced this pull request Mar 2, 2017

Merged

Allow abbreviated post dates #5920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment