Rubocop -a on lib/jekyll #5666
Merged
Rubocop -a on lib/jekyll #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
reviewed
Dec 18, 2016
| def read_static_file(file_path, full_path) | ||
| relative_dir = Jekyll.sanitized_path( | ||
| relative_directory, | ||
| File.dirname(file_path) | ||
| ).chomp("/.") | ||
|
|
||
| files << StaticFile.new(site, site.source, relative_dir, | ||
| File.basename(full_path), self) | ||
| File.basename(full_path), self) |
There was a problem hiding this comment.
whoa! rubocop did this?
may I suggest: ?
files << StaticFile.new(
site,
site.source,
relative_dir,
File.basename(full_path),
self
)
ashmaroli
reviewed
Dec 18, 2016
| @@ -30,8 +30,7 @@ def data | |||
| @data | |||
| end | |||
|
|
|||
| def trigger_hooks(*) | |||
| end | |||
| def trigger_hooks(*); end | |||
There was a problem hiding this comment.
jus curious. why do we have an empty method?
|
noticed this just now.. PRs shouldn't have a |
envygeeks
approved these changes
Dec 18, 2016
envygeeks
approved these changes
Dec 18, 2016
parkr
approved these changes
Dec 18, 2016
|
@jekyllbot: merge +dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5665