Update windows.md #5683
Merged
Update windows.md #5683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an update to installation instructions, as a cert authority change in Ruby causes problems with the prior recommended version of Ruby.
ashmaroli
requested changes
Dec 24, 2016
| @@ -20,6 +20,9 @@ For a more conventional way of installing Jekyll you can follow this [complete g | |||
|
|
|||
| [windows-installjekyll3]: https://labs.sverrirs.com/jekyll/ | |||
|
|
|||
| \[Update 12/23/2016\]: Updates in the infrastructure of Ruby may cause SLL errors when attemptying to use gem install on a version of ruby older than 2.6. (The ruby package installed via the Chocolatey tool is version 2.3) If you have installed an older version, you can update ruby using the directions [here.][ssl-certificate-update] | |||
There was a problem hiding this comment.
Suggesting a couple of edits :
- I don't think including a date is necessary. The information is not fresh-off-the-press and it is understandable by only mentioning the version-number.
- its SSL instead of SLL;
- gem install should be within backticks.:
gem install - its not "...ruby older than 2.6" but "...RubyGems Package older than 2.6."
- again, "The RubyGems package installed via the Chocolatey.."
- ...update RubyGems package using the directions [here]..."
There was a problem hiding this comment.
Thank you for the review, appreciate the feedback!
revising terminology to avoid ambiguity and moving in relation to alternative install instructions.
fixing typo
ashmaroli
reviewed
Dec 24, 2016
| @@ -16,7 +16,7 @@ A quick way to install Jekyll is to follow the [installation instructions by Dav | |||
| 2. Install Ruby via Chocolatey: `choco install ruby -y` | |||
| 3. Reopen a command prompt and install Jekyll: `gem install jekyll` | |||
|
|
|||
| Updates in the infrastructure of Ruby may cause SLL errors when attempting to use `gem install` on a version of the RubyGems package older than 2.6. (The RubyGems package installed via the Chocolatey tool is version 2.3) If you have installed an older version, you can update the RubyGems package using the directions [here.][ssl-certificate-update] | |||
| Updates in the infrastructure of Ruby may cause SSL errors when attempting to use `gem install` on a version of the RubyGems package older than 2.6. (The RubyGems package installed via the Chocolatey tool is version 2.3) If you have installed an older version, you can update the RubyGems package using the directions [here.][ssl-certificate-update] | |||
There was a problem hiding this comment.
How does the following sound? I think its better.. 😉
- when attempting to use `gem install` on a version of the RubyGems package older than 2.6.
+ when attempting to use `gem install` with versions of the RubyGems package older than 2.6.There was a problem hiding this comment.
agreed, it flows better.
ashmaroli
approved these changes
Dec 24, 2016
|
/cc @jekyll/documentation |
DirtyF
approved these changes
Dec 24, 2016
|
What's the appropriate action to take here? Should I be leaving this thread open until someone with write access decides whether to merge it? |
|
@jekyllbot: merge +docs |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an update to installation instructions, as a cert authority change in Ruby causes problems with the prior recommended version of Ruby.