New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows.md #5683

Merged
merged 4 commits into from Jan 1, 2017

Conversation

Projects
None yet
4 participants
@Nursen
Contributor

Nursen commented Dec 23, 2016

Added an update to installation instructions, as a cert authority change in Ruby causes problems with the prior recommended version of Ruby.

Update windows.md
Added an update to installation instructions, as a cert authority change in Ruby causes problems with the prior recommended version of Ruby.
@ashmaroli

Requesting some changes..

Show outdated Hide outdated docs/_docs/windows.md
@@ -20,6 +20,9 @@ For a more conventional way of installing Jekyll you can follow this [complete g
[windows-installjekyll3]: https://labs.sverrirs.com/jekyll/
\[Update 12/23/2016\]: Updates in the infrastructure of Ruby may cause SLL errors when attemptying to use gem install on a version of ruby older than 2.6. (The ruby package installed via the Chocolatey tool is version 2.3) If you have installed an older version, you can update ruby using the directions [here.][ssl-certificate-update]

This comment has been minimized.

@ashmaroli

ashmaroli Dec 24, 2016

Member

Suggesting a couple of edits :

  • I don't think including a date is necessary. The information is not fresh-off-the-press and it is understandable by only mentioning the version-number.
  • its SSL instead of SLL;
  • gem install should be within backticks.: gem install
  • its not "...ruby older than 2.6" but "...RubyGems Package older than 2.6."
  • again, "The RubyGems package installed via the Chocolatey.."
  • ...update RubyGems package using the directions [here]..."
@ashmaroli

ashmaroli Dec 24, 2016

Member

Suggesting a couple of edits :

  • I don't think including a date is necessary. The information is not fresh-off-the-press and it is understandable by only mentioning the version-number.
  • its SSL instead of SLL;
  • gem install should be within backticks.: gem install
  • its not "...ruby older than 2.6" but "...RubyGems Package older than 2.6."
  • again, "The RubyGems package installed via the Chocolatey.."
  • ...update RubyGems package using the directions [here]..."

This comment has been minimized.

@Nursen

Nursen Dec 24, 2016

Contributor

Thank you for the review, appreciate the feedback!

@Nursen

Nursen Dec 24, 2016

Contributor

Thank you for the review, appreciate the feedback!

Nursen added some commits Dec 24, 2016

Update windows.md
revising terminology to avoid ambiguity and moving in relation to alternative install instructions.
Update windows.md
fixing typo
Show outdated Hide outdated docs/_docs/windows.md
@@ -16,7 +16,7 @@ A quick way to install Jekyll is to follow the [installation instructions by Dav
2. Install Ruby via Chocolatey: `choco install ruby -y`
3. Reopen a command prompt and install Jekyll: `gem install jekyll`
Updates in the infrastructure of Ruby may cause SLL errors when attempting to use `gem install` on a version of the RubyGems package older than 2.6. (The RubyGems package installed via the Chocolatey tool is version 2.3) If you have installed an older version, you can update the RubyGems package using the directions [here.][ssl-certificate-update]
Updates in the infrastructure of Ruby may cause SSL errors when attempting to use `gem install` on a version of the RubyGems package older than 2.6. (The RubyGems package installed via the Chocolatey tool is version 2.3) If you have installed an older version, you can update the RubyGems package using the directions [here.][ssl-certificate-update]

This comment has been minimized.

@ashmaroli

ashmaroli Dec 24, 2016

Member

How does the following sound? I think its better.. 😉

- when attempting to use `gem install` on a version of the RubyGems package older than 2.6.
+ when attempting to use `gem install` with versions of the RubyGems package older than 2.6.
@ashmaroli

ashmaroli Dec 24, 2016

Member

How does the following sound? I think its better.. 😉

- when attempting to use `gem install` on a version of the RubyGems package older than 2.6.
+ when attempting to use `gem install` with versions of the RubyGems package older than 2.6.

This comment has been minimized.

@Nursen

Nursen Dec 24, 2016

Contributor

agreed, it flows better.

@Nursen

Nursen Dec 24, 2016

Contributor

agreed, it flows better.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
Member

ashmaroli commented Dec 24, 2016

@DirtyF

DirtyF approved these changes Dec 24, 2016

@DirtyF DirtyF requested a review from oe Dec 24, 2016

@Nursen Nursen closed this Jan 1, 2017

@Nursen Nursen reopened this Jan 1, 2017

@Nursen

This comment has been minimized.

Show comment
Hide comment
@Nursen

Nursen Jan 1, 2017

Contributor

What's the appropriate action to take here? Should I be leaving this thread open until someone with write access decides whether to merge it?

Contributor

Nursen commented Jan 1, 2017

What's the appropriate action to take here? Should I be leaving this thread open until someone with write access decides whether to merge it?

@Nursen Nursen closed this Jan 1, 2017

@Nursen Nursen reopened this Jan 1, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jan 1, 2017

Member

@jekyllbot: merge +docs

Member

DirtyF commented Jan 1, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 0d62e7f into jekyll:master Jan 1, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

jekyllbot added a commit that referenced this pull request Jan 1, 2017

@Nursen

This comment has been minimized.

Show comment
Hide comment
@Nursen

Nursen Jan 1, 2017

Contributor

Thanks!

Contributor

Nursen commented Jan 1, 2017

Thanks!

@Nursen Nursen deleted the Nursen:patch-1 branch Jan 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment