New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jekyll-numbered-headings #5688

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Projects
None yet
7 participants
@muratayusuke
Contributor

muratayusuke commented Dec 25, 2016

I have added a link to my pre-render hook plugin to add ordered number to headings.

jekyll-numbered-headings

Following syntax

##1. At first

###1. One thing

###1. Another thing

##1. Second

##1. Third

will be replaced to:

## 1. At first

### 1.1. One thing

### 1.2. Another thing

## 2. Second

## 3. Third
@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Dec 25, 2016

Member

shouldn't it be : ?

<h2> 1. At first </h2>
<h3> 1.1. One thing </h3>
<h3> 1.2. Another thing </h3>
<h2> 2. Second </h2>
<h2> 3. Third </h2>
Member

ashmaroli commented Dec 25, 2016

shouldn't it be : ?

<h2> 1. At first </h2>
<h3> 1.1. One thing </h3>
<h3> 1.2. Another thing </h3>
<h2> 2. Second </h2>
<h2> 3. Third </h2>
@muratayusuke

This comment has been minimized.

Show comment
Hide comment
@muratayusuke

muratayusuke Dec 25, 2016

Contributor

@ashmaroli This plugin is just pre-render hook, so it doesn't need html conversion. Jekyll convert new markdown into html after this plugin run.

Contributor

muratayusuke commented Dec 25, 2016

@ashmaroli This plugin is just pre-render hook, so it doesn't need html conversion. Jekyll convert new markdown into html after this plugin run.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Dec 25, 2016

Member

oh yeah.. I overlooked that bit.. 👍

Member

ashmaroli commented Dec 25, 2016

oh yeah.. I overlooked that bit.. 👍

@DirtyF

DirtyF approved these changes Dec 25, 2016

@DirtyF DirtyF closed this Dec 25, 2016

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Dec 25, 2016

Member

@jekyllbot: merge +site

Member

DirtyF commented Dec 25, 2016

@jekyllbot: merge +site

@DirtyF DirtyF reopened this Dec 25, 2016

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Dec 25, 2016

Member

wasn't the command: @jekyllbot: merge +docs?

Member

ashmaroli commented Dec 25, 2016

wasn't the command: @jekyllbot: merge +docs?

@crispgm

This comment has been minimized.

Show comment
Hide comment
@crispgm

crispgm Dec 25, 2016

Member

@ashmaroli +site is true to list the plugin on the site.

Member

crispgm commented Dec 25, 2016

@ashmaroli +site is true to list the plugin on the site.

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Dec 25, 2016

Member

@ashmaroli yeah I tried that too, @jekyllbot seems to be on vacation :)

Member

DirtyF commented Dec 25, 2016

@ashmaroli yeah I tried that too, @jekyllbot seems to be on vacation :)

@muratayusuke

This comment has been minimized.

Show comment
Hide comment
@muratayusuke

muratayusuke Jan 6, 2017

Contributor

@DirtyF Is your bot backing from vacation? :)

Contributor

muratayusuke commented Jan 6, 2017

@DirtyF Is your bot backing from vacation? :)

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Jan 6, 2017

Member

@jekyllbot: merge +site

Member

oe commented Jan 6, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit b774147 into jekyll:master Jan 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jan 6, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jan 6, 2017

Member

@muratayusuke seems so 😄

Member

DirtyF commented Jan 6, 2017

@muratayusuke seems so 😄

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Jan 6, 2017

Member

even bots need some time off sometimes!

Member

oe commented Jan 6, 2017

even bots need some time off sometimes!

@muratayusuke muratayusuke deleted the muratayusuke:feature/jekyll-numbered-headings branch Jan 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment