Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jekyll-numbered-headings #5688

Merged

Conversation

muratayusuke
Copy link
Contributor

I have added a link to my pre-render hook plugin to add ordered number to headings.

jekyll-numbered-headings

Following syntax

##1. At first

###1. One thing

###1. Another thing

##1. Second

##1. Third

will be replaced to:

## 1. At first

### 1.1. One thing

### 1.2. Another thing

## 2. Second

## 3. Third

@ashmaroli
Copy link
Member

shouldn't it be : ?

<h2> 1. At first </h2>
<h3> 1.1. One thing </h3>
<h3> 1.2. Another thing </h3>
<h2> 2. Second </h2>
<h2> 3. Third </h2>

@muratayusuke
Copy link
Contributor Author

@ashmaroli This plugin is just pre-render hook, so it doesn't need html conversion. Jekyll convert new markdown into html after this plugin run.

@ashmaroli
Copy link
Member

oh yeah.. I overlooked that bit.. 👍

@DirtyF DirtyF closed this Dec 25, 2016
@DirtyF
Copy link
Member

DirtyF commented Dec 25, 2016

@jekyllbot: merge +site

@DirtyF DirtyF reopened this Dec 25, 2016
@ashmaroli
Copy link
Member

wasn't the command: @jekyllbot: merge +docs?

@crispgm
Copy link
Member

crispgm commented Dec 25, 2016

@ashmaroli +site is true to list the plugin on the site.

@DirtyF
Copy link
Member

DirtyF commented Dec 25, 2016

@ashmaroli yeah I tried that too, @jekyllbot seems to be on vacation :)

@muratayusuke muratayusuke force-pushed the feature/jekyll-numbered-headings branch from 59be2a7 to 657e502 Compare January 6, 2017 06:31
@muratayusuke
Copy link
Contributor Author

muratayusuke commented Jan 6, 2017

@DirtyF Is your bot backing from vacation? :)

@ghost
Copy link

ghost commented Jan 6, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit b774147 into jekyll:master Jan 6, 2017
jekyllbot added a commit that referenced this pull request Jan 6, 2017
@DirtyF
Copy link
Member

DirtyF commented Jan 6, 2017

@muratayusuke seems so 😄

@ghost
Copy link

ghost commented Jan 6, 2017

even bots need some time off sometimes!

@muratayusuke muratayusuke deleted the feature/jekyll-numbered-headings branch January 6, 2017 10:14
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants